Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[choreolib] Add AutoRoutine.observe() #979

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

bryceroethel
Copy link
Contributor

@bryceroethel bryceroethel commented Dec 6, 2024

Adds AutoRoutine.observe(BooleanSupplier condition), which returns a Trigger bound to the routine's event loop. Naming is flexible.

@oh-yes-0-fps
Copy link
Collaborator

I'm still really not a big fan of the name, .listen makes me feel like I'm telling some action to listen for an event to happen and respond where this is really just sanitizing the scope of a Trigger. .sanitize, .associate, or maybe even like .observe if wanna stick with the implications that the AutoRoutine is doing something.

@bryceroethel
Copy link
Contributor Author

I like observe(), implementing now

@bryceroethel bryceroethel changed the title [choreolib] Add AutoRoutine.listen() [choreolib] Add AutoRoutine.observe() Dec 6, 2024
bryceroethel and others added 2 commits December 6, 2024 12:33
Co-authored-by: oh-yes-0-fps <[email protected]>
Co-authored-by: oh-yes-0-fps <[email protected]>
@shueja shueja added this pull request to the merge queue Dec 6, 2024
Merged via the queue into SleipnirGroup:main with commit 4c2dbd8 Dec 6, 2024
32 checks passed
@bryceroethel bryceroethel deleted the listen branch December 25, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants