Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initialize SDK with httpClient, add HttpResponseMessage to Exception #93

Merged
merged 6 commits into from
Jun 28, 2024
Merged

feat: initialize SDK with httpClient, add HttpResponseMessage to Exception #93

merged 6 commits into from
Jun 28, 2024

Conversation

jpill
Copy link
Member

@jpill jpill commented Jun 27, 2024

  • Adds the ability to initialize SDK with an HttpClient
  • Adds cancellation token to client
  • Adds HttpResponseMessage to ShipEngineException
  • Adds missing markdown
  • Redefines several properties as nullable reference types

@jpill jpill mentioned this pull request Jun 27, 2024
Closed
semarj
semarj approved these changes Jun 28, 2024
View reviewed changes
ShipEngine/Models/ShipEngineException.cs Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9713983229

Details

  • 47 of 126 (37.3%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-8.2%) to 77.123%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ShipEngine/Models/Dto/GetRatesFromShipmentDetails/Result.cs 19 23 82.61%
ShipEngine/ShipEngineClient.cs 16 20 80.0%
ShipEngine/ShipEngine.cs 2 73 2.74%
Files with Coverage Reduction New Missed Lines %
ShipEngine/ShipEngine.cs 1 57.84%
ShipEngine/ShipEngineClient.cs 1 77.98%
Totals Coverage Status
Change from base Build 9687758516: -8.2%
Covered Lines: 642
Relevant Lines: 809
💛 - Coveralls

@jpill jpill merged commit 561e3af into main Jun 28, 2024
5 checks passed
@jpill jpill deleted the jpill/include-http-response-with-error branch June 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semarj semarj semarj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpill @coveralls @semarj