feat: add method to initialize SDK with an httpClient #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jpill
commented
Jun 10, 2024
•
jpill
commented
- Adds the ability to initialize SDK with an HttpClient, and to make modifications to subsequent requests
- Adds cancellation token to client
- Adds HttpResponseMessage to ShipEngineException
- Adds missing markdown
- Redefines several properties as nullable reference types
- Adds and implements IShipEngine interface with virtual mockable ShipEngine
jpill
force-pushed
the
jpill/HttpClient-update
branch
2 times, most recently
from
55403e4 to
ac8aa05
Compare
jpill
force-pushed
the
jpill/HttpClient-update
branch
2 times, most recently
from
ed17c45 to
9c6b2a7
Compare
jpill
force-pushed
the
jpill/HttpClient-update
branch
from
0325572 to
4ec67cd
Compare
jpill
force-pushed
the
jpill/HttpClient-update
branch
from
4ec67cd to
9d3ad15
Compare
jpill
force-pushed
the
jpill/HttpClient-update
branch
from
9d3ad15 to
6a2afce
Compare
jpill
force-pushed
the
jpill/HttpClient-update
branch
from
6a2afce to
e4739f7
Compare
Pull Request Test Coverage Report for Build 9652824702Details
💛 - Coveralls |
jpill
force-pushed
the
jpill/HttpClient-update
branch
from
0f79f4b to
6c7b334
Compare
Pull Request Test Coverage Report for Build 9664624594Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9664647461Details
💛 - Coveralls |
| Converters = { new JsonStringEnumMemberConverter() } | ||
| }; | ||
| } | ||
| protected Action<HttpRequestMessage>? ModifyRequest { get; set; } |
There was a problem hiding this comment.
Does this need to be protected? We want users to be able to set it. I know we talked about a .WithModifiedRequest() method that would return a new instance with this field set, but is there any reason to force them to use that method? Seems like it should be fine to let people do client.ModifyRequest = r => ... as well
There was a problem hiding this comment.
fair question - I think likely not, but am just going to remove the modify request bit from this effort while that gets further consideration, so as not to cause more delay with the rest of the functionality I'm looking to deliver here
| { | ||
| client.DefaultRequestHeaders.Accept.Clear(); | ||
|
|
||
| var osPlatform = Environment.OSVersion.Platform.ToString(); |
There was a problem hiding this comment.
The duplication of all of this logic seems wrong. Can the non-static version invoke the static version?
There was a problem hiding this comment.
good callout, I have modified this in the updated PR here: #93
|
closing this PR in favor of #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.