-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form Builder & Form Scope #213
Conversation
…fferent statuses of an api response
feat: Added `MiraiNetworkResult` type in mirai/network_request to handle different statuses
…network-request fix: Asim/form builder/export network request
…in the controller.
… like KYC submit and renamed it to `body`
…action-parsers feat: Added export for action models and parsers in mirai/action_parsers
…-type-data-change-to-dynamic Converted request body<data> to dynamic type to handle `List` in apis…
…network-service Exported `services` in mirai framework
…quest-body feat: Updated form request body to handle `Files`
… it fails or returns null
…quest-body feat: Returning `formdata` in body construction for multi-part post requests in Mirai network service
…-request-body Asim/form builder/updated request body
Signed-off-by: Divyanshu Bhargava <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this pull request. I have added a few comments.
packages/mirai/lib/src/parsers/mirai_check_box_widget/mirai_check_box_widget_parser.dart
Show resolved
Hide resolved
context | ||
.read<MiraiFormCubit>() | ||
.registerValue(widget.model.id!, widget.model.initialValue ?? ""); | ||
// context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this commented code?
packages/mirai/lib/src/parsers/mirai_text_form_field/mirai_text_form_field_parser.dart
Show resolved
Hide resolved
Also, |
feat: Added dynamic values in network headers
fix: Removed imports from `mirai.dart` and rebuilt packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!!
Description
Related Issues
Type of Change