Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Builder & Form Scope #213

Closed
wants to merge 45 commits into from
Closed

Form Builder & Form Scope #213

wants to merge 45 commits into from

Conversation

divyanshub024
Copy link
Contributor

@divyanshub024 divyanshub024 commented Sep 22, 2023

Description

Related Issues

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

feat: Added `MiraiNetworkResult` type in mirai/network_request to handle different statuses
…network-request

fix: Asim/form builder/export network request
…action-parsers

feat: Added export for action models and parsers in mirai/action_parsers
…-type-data-change-to-dynamic

Converted request body<data> to dynamic type to handle `List` in apis…
…network-service

Exported `services` in mirai framework
…quest-body

feat: Updated form request body to handle `Files`
…quest-body

feat: Returning `formdata` in body construction for multi-part post requests in Mirai network service
@divyanshub024 divyanshub024 marked this pull request as ready for review October 17, 2023 06:43
@divyanshub024 divyanshub024 changed the title [Draft] Form Builder & Form Scope Form Builder & Form Scope Oct 17, 2023
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request. I have added a few comments.

examples/mirai_gallery/pubspec.yaml Show resolved Hide resolved
context
.read<MiraiFormCubit>()
.registerValue(widget.model.id!, widget.model.initialValue ?? "");
// context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this commented code?

@i-asimkhan
Copy link
Contributor

Also, melos build changes some files we need to do it once.

@divyanshub024 divyanshub024 added this to the v0.6 milestone Jan 26, 2024
@divyanshub024 divyanshub024 modified the milestones: v0.6, v0.7 Feb 13, 2024
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!!

@divyanshub024 divyanshub024 removed this from the v0.7 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants