Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added export for mirai_form_cubit in mirai_form #228

Closed
wants to merge 1 commit into from
Closed

fix: Added export for mirai_form_cubit in mirai_form #228

wants to merge 1 commit into from

Conversation

i-asimkhan
Copy link
Contributor

Description

Allow MiraiFormCubit to be accessed and used in overlying apps built with Mirai.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@i-asimkhan i-asimkhan mentioned this pull request Oct 16, 2023
Open
@divyanshub024
Copy link
Contributor

@i-asimkhan Do we need it? After merging #213 we don;t need cubit.

@i-asimkhan
Copy link
Contributor Author

@i-asimkhan Do we need it? After merging #213 we don;t need cubit.

Yes, you are right after #213 we will not be needing this.

@i-asimkhan
Copy link
Contributor Author

Since #213 will remove cubit so we need to close this.

@i-asimkhan i-asimkhan closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshub024 divyanshub024 Awaiting requested review from divyanshub024

Assignees

@i-asimkhan i-asimkhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-asimkhan @divyanshub024