ci: use reusable formatting workflow #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thazhemadam
force-pushed
the
at/use-centralized-workflows
branch
3 times, most recently
from
1a62447 to
4eb600a
Compare
|
How's this? |
|
There still seems to be a few issues that I'm working out. But the general set up itself works. |
thazhemadam
force-pushed
the
at/use-centralized-workflows
branch
2 times, most recently
from
4848093 to
e275d81
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
thazhemadam
force-pushed
the
at/use-centralized-workflows
branch
from
e3b1676 to
113fc4b
Compare
Update the workflow to directly use the centralized, reusable format checking workflow defined for SciML repositories.
thazhemadam
force-pushed
the
at/use-centralized-workflows
branch
from
1a4dcbc to
fe10c22
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Is this one supposed to show up as not run? |
Yes. The "Comment Formatting Suggestions" step is run only if there are actually formatting suggestions that need to be commented. If the format checks are passing, then that job isn't run. |
|
That looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use organisation wide formatting workflow.