Skip to content

Commit

Permalink
ci(format-check): use centralized, reusable SciML format check workflow
Browse files Browse the repository at this point in the history
Update the workflow to directly use the centralized, reusable format
checking workflow defined for SciML repositories.
  • Loading branch information
thazhemadam committed Apr 8, 2024
1 parent 3f715e6 commit fe10c22
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 33 deletions.
36 changes: 4 additions & 32 deletions .github/workflows/FormatCheck.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: format-check
name: "Format Check"

on:
push:
Expand All @@ -9,34 +9,6 @@ on:
pull_request:

jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
julia-version: [1]
julia-arch: [x86]
os: [ubuntu-latest]
steps:
- uses: julia-actions/setup-julia@latest
with:
version: ${{ matrix.julia-version }}

- uses: actions/checkout@v4
- name: Install JuliaFormatter and format
# This will use the latest version by default but you can set the version like so:
#
# julia -e 'using Pkg; Pkg.add(PackageSpec(name="JuliaFormatter", version="0.13.0"))'
run: |
julia -e 'using Pkg; Pkg.add(PackageSpec(name="JuliaFormatter"))'
julia -e 'using JuliaFormatter; format(".", verbose=true)'
- name: Format check
run: |
julia -e '
out = Cmd(`git diff --name-only`) |> read |> String
if out == ""
exit(0)
else
@error "Some files have not been formatted !!!"
write(stdout, out)
exit(1)
end'
format-check:
name: "Format Checks"
uses: "SciML/.github/.github/workflows/format-suggestions-on-pr.yml@014c98428fa1165dbf01478156359253f984fb0a"
3 changes: 2 additions & 1 deletion src/krylov_phiv_adaptive.jl
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ intuitive interface (vector `b` instead of a n-by-1 matrix `B`).
evaluating the φ-functions in exponential integrators. arXiv preprint
arXiv:0907.4631.
"""
function expv_timestep(ts::Vector{tType}, A, b; kwargs...) where {tType <: Real}
function expv_timestep(ts::Vector{tType},
A, b; kwargs...) where {tType <: Real}
U = similar(b, size(A, 1), length(ts))
expv_timestep!(U, ts, A, b; kwargs...)
end
Expand Down

0 comments on commit fe10c22

Please sign in to comment.