Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

187 - pyside6 #208

Merged
merged 247 commits into from
Mar 7, 2023
Merged

187 - pyside6 #208

merged 247 commits into from
Mar 7, 2023

Conversation

mxochicale
Copy link
Contributor

@mxochicale mxochicale commented Mar 2, 2023 •
edited
Loading

Hi @thompson318

This PR is ready to review. It solves the following issues:

Let me know if you have feedback or comments. Otherwise, 187-pyside6 should be ready to be merged and tag it as v2.0rc1.
Thanks

thompson318 and others added 30 commits January 24, 2023 12:47
@thompson318 @mxochicale
Issue #187 changes pyside2 to pyside6
509750f
@thompson318 @mxochicale
Issue #187 requirements match setup
d98aeaf
@thompson318 @mxochicale
Issue #187 try installing libgl1
43b85b9
@thompson318 @mxochicale
Issue #187 libegl-dev
9acfd6f
@thompson318 @mxochicale
Issue #187 set margins depreciated, use setcontentsmargins
cd2cef3
@thompson318 @mxochicale
Issue #187 add close event and finalize the widget
872512d
@thompson318 @mxochicale
Issue #187 add close to test rendering generator
219b005
@thompson318 @mxochicale
Issue #187 pylint updates
9aa5125
@thompson318 @mxochicale
Issue #181 addes finalize to stereo widget
9564cc3
@thompson318 @mxochicale
Issue #181 try holding back vtk version
c5744fc
@thompson318 @mxochicale
Issue #187 removed old library path from ci.yml
c699bad
@thompson318 @mxochicale
Issue #187 try using pytest-qt-app
62ab63f
@thompson318 @mxochicale
Issue #187 put library path back in
396b74e
@thompson318 @mxochicale
Issue #187 put xvfb back in
c088c3a
@mxochicale
updates pyside6 in docs/tuto../overlay_window.ipynb; (#187)
59fa469
@mxochicale
removes duplicated closeEvent (#187)
2e240fb
@mxochicale
optimises imports; fixes typos; (#187)
8ac5039
@mxochicale
in ci.yml adds python version from matrix & adds -v -s for pytest; (#187
4d69a7c 
)
@mxochicale
optimise imports conftest.py; adds init_widget in setup_vtk_overlay_w…
a5ac3ce 
…indow; (#187)
@mxochicale
init_widget=True in setup_vtk_overlay_window > conftest.py (#187)
b21a9f8
@mxochicale
init_widget_flag with platform.system(), sorting out local tests (#187)
c0e1d5b
@mxochicale
adds else for other OSs with init_widget_flag=True (#187)
ad64fda
@mxochicale
adds namigs for used and nonused variables and optimise imports for t…
a446265 
…est_vtk_overlay_window; (#187)
@mxochicale
uses platform.system; optimise imports; reformat code > test_liver_ov…
52a3cc6 
…erlay.py; (#187)
@mxochicale
adding better variable naming @ test_liver_overlay.py (#202; #187)
8cf0d9e
@mxochicale
reset to 8cf0d9e and renamed input_image_file (#187)
8d9d483
@mxochicale
updates PySide6 in tox.ini; (#187)
44a6f6d
@mxochicale
to test only conftest.py and test_requirements; (#187)
51bd4fc
@mxochicale
adds sudo apt-get update in ci to sort libegl-dev 404 not found; (#187)
1b14924
@mxochicale
✔️ local unit tests/models/test_surface_model_loader.py; (#203, #187)
27ad53c
@mxochicale
adds 3.12-dev to ci.yml (#187, #202, #203)
9d829cb
@mxochicale
adds 3.12 to ci.yml experimental (#187, #202, #203)
dcb6aea
@mxochicale
updates version of actions in ci.yml (#187, #202, #203)
d5f5149
@mxochicale
setting up 3.12-dev to ci.yml (#187, #202, #203)
6049a22
@mxochicale
✔️ passed local test of tests/widgets/test_interlaced_stereo_window.p…
4d1bd38 
…y::test_stereo_overlay_window but screen is black; refactors VTKStereoInterlacedWindow; (#187, #202, #203)
@mxochicale
✔️ 155 tests passed locally; adds decorator @skiplinux_pytest tests/w…
989f9d7 
…idgets/test_rendering_generator.py; (#187, #202, #203)
@mxochicale
renames decorator as @skip_pytest_in_linux (#187, #202, #203)
aad044d
@mxochicale
✔️ 156 tests passed locally; adding tests/text/test_vtk_text.py::test…
7e43034 
…_window_resize (#187, #202, #203)
@mxochicale
✔️ adds decorator @skip_pytest_in_oss to skip in all OSs tests/text/t…
fa1f29e 
…est_vtk_text.py::test_window_resize (#187, #202, #203)
@mxochicale
✔️ 154 tests passed locally; adds decorator @skip_pytest_in_oss tests…
5852916 
…/widgets/test_interlaced_stereo_window.py (#187, #202, #203)
@mxochicale
locally pass by uncommenting first lines of tests/widgets/test_lus_si…
09bd3ef 
…mulator.py (#187, #202, #203)
@mxochicale
local failures by uncommenting lus.VTKLUSSimulator in tests/widgets/t…
9e42d27 
…est_lus_simulator.py::test_basic_rendering_generator (#187, #202, #203)
@mxochicale
unit test in linux is not stable as it fails due to innapropriate cla…
18aa2a6 
…ss inherirtance; also refactors prints in tests/widgets/test_lus_simulator.py::test_basic_rendering_generator (#187, #202, #203)
@mxochicale
unit test in linux is not stable as it fails due to innapropriate cla…
1d0a681 
…ss inherirtance; tests/widgets/test_lus_simulator.py::test_matrices_rendering_generator (#187, #202, #203)
@mxochicale
adds decorator @skip_pytest_in_linux_and_none_ci for tests/widgets/te…
a9c67fb 
…st_lus_simulator.py (#187, #202, #203)
@mxochicale
removes python-ver 3.7 in ci.yml due to end-of-support 2023-06-27; de…
fc6e295 
…ploy in ubuntu22.02 py38; updates pyversion to 3.8 in tox (#187, #202, #203)
@mxochicale
comments widget_vtk_overlay.Start() in tests/camera/test_liver_overla…
1073cc9 
…y.py::test_overlay_liver_points (#187, #202, #203)
@mxochicale
removes docs/tutorials/overlay_window.ipynb and updates tox for docs (#…
a2ac8ce 
…187, #202, #203, #206)
@mxochicale
update main README.rst & minor changes in CONTRIBUTING.rst (#187)
5d8c8f8
@mxochicale
fix links in main README.rst (#187)
2bc29dd
@mxochicale mxochicale requested a review from thompson318 March 2, 2023 12:42
@mxochicale
Copy link
Contributor Author

Hi @thompson318

See Summary of unit tests and coverage for py38 for local and remote unit tests: #187 (comment). Let me know if you further comments or feedback, otherwise this PR should be ready to be merged.

Thanks
Miguel

@thompson318 thompson318 merged commit 3fa59d5 into master Mar 7, 2023
@thompson318 thompson318 deleted the 187-pyside6 branch March 7, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompson318 thompson318 Awaiting requested review from thompson318

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxochicale @thompson318 @MattClarkson