Multi-NIC Bug Fix: Set 'next' attribute of list tail to NULL #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrrobin
approved these changes
Apr 15, 2024
davidozog
approved these changes
Apr 15, 2024
wrrobin
reviewed
Apr 15, 2024
src/transport_ofi.c
Outdated
| @@ -1562,6 +1562,7 @@ int query_for_fabric(struct fabric_info *info) | |||
| multirail_fabric_list_tail = cur_fabric; | |||
| } | |||
| } | |||
| multirail_fabric_list_tail->next = NULL; | |||
There was a problem hiding this comment.
This can generate a null pointer assignment if it is not assigned within the for loop above.
There was a problem hiding this comment.
Just realized, it might have been causing the failure in the testing as well. Please check.
There was a problem hiding this comment.
Looks like it was the cause of the test failure. Thanks for catching it!
davidozog
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a minor bug fix to the code that is responsible for generating a list of providers that have NIC information. This should resolve the issues we were seeing on some of our development systems that have a single NIC when SOS is being used with multi-NIC functionality enabled.