Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-NIC Bug Fix: Set 'next' attribute of list tail to NULL #1119

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Multi-NIC Bug Fix: Set 'next' attribute of list tail to NULL #1119

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0f0e30
src: Set 'next' attribute of list tail to NULL
Apr 15, 2024
5b829e8
src: Add Wasi's recommended fix
Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/transport_ofi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,6 +1562,7 @@ int query_for_fabric(struct fabric_info *info)
multirail_fabric_list_tail = cur_fabric;
}
}
multirail_fabric_list_tail->next = NULL;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can generate a null pointer assignment if it is not assigned within the for loop above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized, it might have been causing the failure in the testing as well. Please check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was the cause of the test failure. Thanks for catching it!


if (num_nics == 0) {
info->p_info = fallback;
Expand Down
Loading