rtl8730e_boot.c: bringup gpio PB22 pin for lcd #6533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritesh55555
changed the title
ritesh55555
force-pushed
the
lcd_pin
branch
3 times, most recently
from
7726ffd to
21e86d1
Compare
| @@ -242,6 +242,7 @@ void board_gpio_initialize(void) | |||
| {PA_23, PIN_INPUT, PullNone}, | |||
| /* PB_20 is gpio pin number for LED */ | |||
| {PB_20, PIN_OUTPUT, PullDown}, | |||
| {PB_22, PIN_OUTPUT, PullNone}, | |||
There was a problem hiding this comment.
- It should be PIN_INPUT. (My previous comment was wrong)
- Let me suggest the title like below
board/rtl8730e: set PB_22 GPIO pin to get outside wakeup event
The PB_22 pin will be registered as a wakeup source and will get a wakeup event from outside.
ewoodev
reviewed
Dec 2, 2024
| @@ -242,6 +242,7 @@ void board_gpio_initialize(void) | |||
| {PA_23, PIN_INPUT, PullNone}, | |||
| /* PB_20 is gpio pin number for LED */ | |||
| {PB_20, PIN_OUTPUT, PullDown}, | |||
| {PB_22, PIN_OUTPUT, PullNone}, | |||
There was a problem hiding this comment.
os/arch/arm/src/amebasmart/amebasmart_i2s.c
.i2s_mclk_pin = PB_22,
PB22 pin is setting I2S2 mclk.
We need to check first if we can change I2S2 mclk to un-used pin
There was a problem hiding this comment.
rtk will raise PR about I2S2,
@ritesh55555 Let's merge your PR, Please update
- The PB_22 pin will be registered as a wakeup source and will get a wakeup event from outside.
ewoodev
approved these changes
Dec 2, 2024
ritesh55555
changed the title
r-prabu
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings up PB22 gpio pin. This pin will be used as wake up source for lcd.