build/tools/amebasmart/gnu_utility: Enable GPIO B for wakeup src inte… #6546
Conversation
|
Please take note for PA_4 to be wakeup src, CONFIG_RTL8730E_BOARD_REVISION needs to be >=5, else PA_4 is used as UART1 rx. Hi @ewoodev, since PB22 is required as a GPIO wakeup source, it cannot be use for I2S2 MCLK concurrently, I will PR separately to remove i2s2 mclk. From my understanding, I2S2 MCLK is not required for the current setting, so i will set it as NULL and not do any pinmux for it. Please let me know if my understanding is wrong. Test results: Thank you |
…rrupt 1. enable GPIO B for wakeup src interrupt
zhongnuo-tang
force-pushed
the
GPIOB_wakeup_src
branch
from
0be534c
to
28e2ec2
Compare
|
PR #6549 to remove PB22 in I2S2 |
| @@ -240,8 +240,10 @@ void board_gpio_initialize(void) | |||
| u32 pinpull; | |||
| } pins[] = { | |||
| {PA_23, PIN_INPUT, PullNone}, | |||
| {PA_4, PIN_INPUT, PullNone}, | |||
There was a problem hiding this comment.
since this is only supported for board revision smaller than 5, you should add this
#if CONFIG_RTL8730E_BOARD_REVISION < 5
There was a problem hiding this comment.
I can add the condition here #if CONFIG_RTL8730E_BOARD_REVISION >= 5, but that needs I2C1 to be disabled (I2C1 is not used).
Hi @sunghan-chang ,
Do you think we should introduce other macro for such gpio wakeup pin? As either >=5 or <5 have peripheral uses PA_4, it might create unnecessary issue.
| @@ -240,8 +240,10 @@ void board_gpio_initialize(void) | |||
| u32 pinpull; | |||
| } pins[] = { | |||
| {PA_23, PIN_INPUT, PullNone}, | |||
| {PA_4, PIN_INPUT, PullNone}, | |||
There was a problem hiding this comment.
Please remove it in here.
we have no plan to register gpio driver about this pin.
| /* PB_20 is gpio pin number for LED */ | ||
| {PB_20, PIN_OUTPUT, PullDown}, | ||
| {PB_22, PIN_INPUT, PullNone}, |
There was a problem hiding this comment.
#6533
This changing is duplicating, Could you please remove it here?
…rrupt