[cker] Introduce cker for avgpool #14086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icodo98
force-pushed
the
cker-avgpool
branch
from
9007319 to
ca8adda
Compare
This commit add chekr for average pooling ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
icodo98
force-pushed
the
cker-avgpool
branch
from
ca8adda to
3f3785e
Compare
ragmani
reviewed
Sep 25, 2024
zetwhite
reviewed
Sep 26, 2024
| out_mat.cwiseMin(params.float_activation_min).cwiseMax(params.float_activation_max); | ||
| } | ||
|
|
||
| inline void AvgPool2DGrad(const PoolParams ¶ms, const Shape &incoming_shape, |
There was a problem hiding this comment.
Could you add the backward formula for avgpool, here? #11248
zetwhite
reviewed
Sep 26, 2024
| AvgPoolOpVerifier<float> verifier(op_param, in, out); | ||
|
|
||
| /** | ||
| * input(index) : output(arg-count): |
There was a problem hiding this comment.
(optional)
Ah, If you followed the maxpool2d notation, maxpool2d expressed the index - because one output of maxpool2d is about index.
For avergepool2d, index isn't important, I guess you don't need to mark the index here.
If you have another intention about index plz let me know.
zetwhite
reviewed
Sep 26, 2024
| AvgPoolOpVerifier<float> verifier(op_param, in, out); | ||
|
|
||
| /** | ||
| * input(index) : output(arg-count): |
There was a problem hiding this comment.
Suggested change
| * input(index) : output(arg-count): | |
| * input : output(arg-count): |
There was a problem hiding this comment.
Ah, If you followed the
maxpool2dnotation
I did follow the maxpool2d notation. I'll remove it.
use existing forwarding function. update notaion. ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
|
I update it! |
glistening
reviewed
Sep 29, 2024
| * limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef __NNFW_CKER_TRAIN_OPERATION_AVGPOOL_H__ |
There was a problem hiding this comment.
Suggested change
| #ifndef __NNFW_CKER_TRAIN_OPERATION_AVGPOOL_H__ | |
| #ifndef __NNFW_CKER_TRAIN_OPERATION_AVERAGEPOOL_H__ |
Same to the following two occurrences
This commit updates header guard. ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
zetwhite
approved these changes
Sep 30, 2024
ragmani
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce cker for average pooling operation.
ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]