Various RAM map documentation and alignment with SA3 #175
Conversation
| @@ -35,7 +35,8 @@ u8 gNumHBlankIntrs = 0; | |||
| struct BlendRegs gBldRegs ALIGNED(8) = {}; | |||
| u8 gOamFreeIndex = 0; | |||
| struct Task gEmptyTask ALIGNED(16) = {}; | |||
| BgAffineReg gBgAffineRegs[NUM_AFFINE_BACKGROUNDS] ALIGNED(8) = {}; | |||
| u8 gNextFreeAffineIndex = 0; | |||
There was a problem hiding this comment.
Ok, so I understand that including this means that we don't need to ALIGNED(8) the struct, but all structs are 8 aligned so I don't think the 8 align is because this var was actually here. Think I'd be happier with the CURRENT_GAME macro here too?
There was a problem hiding this comment.
I'd say it just means that there are more variables we need to uncover.
The space here didn't just appear at random.
And I actually had the #if here initially, but decided to remove it because it's not needed for matching.
There was a problem hiding this comment.
No, I don't think so. Structs are always 16 aligned and arrays are always 8 aligned. I'm ok with the extra if for accuracy
src/core.c
Outdated
| @@ -251,7 +253,7 @@ void GameInit(void) | |||
| gBgAffineRegs[1].x = 0; | |||
| gBgAffineRegs[1].y = 0; | |||
|
|
|||
| #if (CURRENT_GAME >= GAME_SA3) | |||
| #if (GAME >= GAME_SA3) | |||
There was a problem hiding this comment.
Shouldn't this be engine ;)
There was a problem hiding this comment.
It's inside Gameinit, so... no?
| @@ -1,4 +1,5 @@ | |||
| #include "global.h" | |||
| #include "game/game.h" | |||
There was a problem hiding this comment.
No longer needed since it moved to config.h
No description provided.