Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude pre-1.60 crates from workspace #1380

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Exclude pre-1.60 crates from workspace #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d3f075
Exclude pre-1.60 crates from workspace
tarcieri Nov 11, 2023
8528581
clippy fixes
tarcieri Nov 11, 2023
acc7ebb
async-signature: fix minimal-versions CI workflow
tarcieri Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/async-signature.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: RustCrypto/actions/cargo-cache@master
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
- uses: dtolnay/rust-toolchain@nightly
- run: cargo update -Z minimal-versions
- uses: dtolnay/rust-toolchain@stable
- uses: RustCrypto/actions/cargo-hack-install@master
- run: rm ../../Cargo.toml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use the shared workflow due to this, FYI (it's nested a level deeper than usual)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to move async-signature to the top level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it would help with things like this. There's some open PRs though, so we'd need to get those merged first.

- run: cargo update -Z minimal-versions
- run: cargo hack test --release --feature-powerset
11 changes: 0 additions & 11 deletions .github/workflows/crypto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,3 @@ jobs:
- run: cargo test --no-default-features --release
- run: cargo test --release
- run: cargo test --all-features --release

clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: RustCrypto/actions/cargo-cache@master
- uses: dtolnay/rust-toolchain@master
with:
toolchain: 1.65.0
components: clippy
- run: cargo clippy --all --all-features -- -D warnings
4 changes: 0 additions & 4 deletions .github/workflows/universal-hash.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ jobs:
with:
toolchain: ${{ matrix.rust }}
targets: ${{ matrix.target }}
# Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
- run: rm ../Cargo.toml
- run: cargo build --no-default-features --release --target ${{ matrix.target }}

minimal-versions:
Expand All @@ -56,8 +54,6 @@ jobs:
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ matrix.rust }}
# Isolate this crate from workspace which is otherwise MSRV 1.56 due to 2021 edition crates
- run: rm ../Cargo.toml
- run: cargo check --all-features
- run: cargo test --no-default-features --release
- run: cargo test --release
Expand Down
Loading
Loading