Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude pre-1.60 crates from workspace #1380

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

tarcieri
Copy link
Member

Pre-1.60 crates can't be used in workspaces with other crates that use namespaced/weak features.

This commit places all MSRV 1.60+ crates into members and moves the ones with earlier MSRVs into exclude.

Pre-1.60 crates can't be used in workspaces with other crates that use
namespaced/weak features.

This commit places all MSRV 1.60+ crates into `members` and moves the
ones with earlier MSRVs into `exclude`.
@tarcieri tarcieri force-pushed the exclude-pre-1.60-crates-from-workspace branch from 57b0862 to 1d3f075 Compare November 11, 2023 22:59
@tarcieri tarcieri force-pushed the exclude-pre-1.60-crates-from-workspace branch 2 times, most recently from d13b1ec to 85a0ccd Compare November 12, 2023 00:20
@tarcieri tarcieri force-pushed the exclude-pre-1.60-crates-from-workspace branch from 85a0ccd to acc7ebb Compare November 12, 2023 00:35
@tarcieri
Copy link
Member Author

Okay, that should hopefully make it green.

This will result in clippy and rustfmt being skipped for the crates in exclude, but I think we can just rapidly iterate on getting those crates upgraded to be MSRV 1.60+ (e.g. by doing crypto-common upgrades)

@tarcieri tarcieri requested a review from newpavlov November 12, 2023 00:53
toolchain: nightly
- uses: dtolnay/rust-toolchain@nightly
- run: cargo update -Z minimal-versions
- uses: dtolnay/rust-toolchain@stable
- uses: RustCrypto/actions/cargo-hack-install@master
- run: rm ../../Cargo.toml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use the shared workflow due to this, FYI (it's nested a level deeper than usual)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to move async-signature to the top level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it would help with things like this. There's some open PRs though, so we'd need to get those merged first.

@tarcieri
Copy link
Member Author

Going to go ahead and merge this so I can PR the getrandom feature for crypto-common (which would be helpful for bumping crypto-common in aead)

@tarcieri tarcieri merged commit 1d0810d into master Nov 12, 2023
84 checks passed
@tarcieri tarcieri deleted the exclude-pre-1.60-crates-from-workspace branch November 12, 2023 01:01
toolchain: nightly
- uses: dtolnay/rust-toolchain@nightly
- run: cargo update -Z minimal-versions
- uses: dtolnay/rust-toolchain@stable
- uses: RustCrypto/actions/cargo-hack-install@master
- run: rm ../../Cargo.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to move async-signature to the top level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants