Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12596] Part of issue the table doesn't sort by team #1

Draft
wants to merge 400 commits into
base: master
Choose a base branch
from
Draft

[#12596] Part of issue the table doesn't sort by team #1

wants to merge 400 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Feb 18, 2024

  1. [#12048] Migrate instructor search indexing worker action (#12731) 

    * Fix lint

* Migrate instructor search indexing worker action

* Fix Checkstyle

* Fix Checkstyle

* Fix Checkstyle

* Add testcases

* Update comparator to Id

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Nicolas <[email protected]>
    @mingyuanc @cedricongjh @NicolasCwy
    3 people authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    8e757e2 View commit details
    Browse the repository at this point in the history

  2. [#12048] Add tests for CoursesLogic (#12746) 

    * feat: add tests for CoursesLogic

* fix: verify parameters of mocked logic classes

* fix: lint issues

* fix: add additional verification of parameters

---------

Co-authored-by: Cedric Ong <[email protected]>
    @domoberzin @cedricongjh
    domoberzin and cedricongjh authored Feb 18, 2024
    Configuration menu
    Copy the full SHA
    c314aa9 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Add test for getUsageStatisticsForTimeRange (#12748)

    @cedricongjh
    cedricongjh authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    20712f5 View commit details
    Browse the repository at this point in the history

  2. [#12048] Migrate SubmitFeedbackResponseAction's Logic and Db methods (#… 

    …12732)

* Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade

---------

Co-authored-by: Nicolas <[email protected]>
    @FergusMok @NicolasCwy
    FergusMok and NicolasCwy authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    02b710d View commit details
    Browse the repository at this point in the history

  3. Add testcases for FeedbackResponseCommentsDbTest (#12755) 

    * Add CRUD testcases

* Fix linting

* Refactor getTypicalComment

* Amend testDeleteComment testcase

* Amend testDeleteComment testcase

* Fix compile error

* Revert linting changes

---------

Co-authored-by: Nicolas <[email protected]>
    @mingyuanc @NicolasCwy
    mingyuanc and NicolasCwy authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d6c67fc View commit details
    Browse the repository at this point in the history

  4. [#12048] Migrate FeedbackSessionOpeningSoonRemindersAction (#12740) 

    * update logic

* add it test for action

* fix checkstyle errors
    @EuniceSim142
    EuniceSim142 authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    31e44fa View commit details
    Browse the repository at this point in the history

  5. [#12048] Migrate SubmitFeedbackResponseAction (#12720) 

    * Initial draft for migrated

Remove unnecessary comments

Remove unnecessary comments

Save progress

Add draft

Add draft

* Add tests

* Add implementation

* Add implementation

* Add implementation

* Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade

* Revert unnecessary changes, add tests

* Fix linting and tests

* Merge changes with db

* Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade

* Revert unnecessary changes, add tests

* Fix linting and tests

* Save progress

* Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade

Revert unnecessary changes, add tests

Fix linting and tests

Add changes

Revert changes

Revert changes

Add tests

Add lint changes

* Fix linting errors

* Clean up commits

* Disable failing test

* Replace giver with updatedAt to make test clearer

* Add IT setUp

* Save progress on tests

* Revert test-related changes

* Revert test-related changes, clean linting

* Correct spelling mistakes

---------

Co-authored-by: Cedric Ong <[email protected]>
    @FergusMok @cedricongjh
    FergusMok and cedricongjh authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    70f7801 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. [#12048] Migrate AccountRequestSearchIndexingWorkerAction (#12757) 

    * feat: migrate account request search indexing worker action

* fix: remove datastore logic and old test

* fix: remove NPE suppress
    @domoberzin
    domoberzin authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    daba8eb View commit details
    Browse the repository at this point in the history

  2. [#12048] Migrate FeedbackSessionClosingRemindersAction (#12743) 

    * update action logic

* add it test and fix email-gen logic

* fix checkstyle errors

* minor fix 1

* add missing migrated check

* fix checkstyle

* fix checkstyle
    @EuniceSim142
    EuniceSim142 authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9744f68 View commit details
    Browse the repository at this point in the history

  3. [#12048] Migrate FeedbackSessionClosedRemindersAction (#12738) 

    * update logic

* add sql it test

* fix linting errors

* fix isClosed logic

* fix checkstyle errors

* implement code changes from pr review

* fix checkstyle

* fix checkstyle
    @EuniceSim142
    EuniceSim142 authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2eec90c View commit details
    Browse the repository at this point in the history

  4. Add config for e2e sql tests (#12762)

    @cedricongjh
    cedricongjh authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d7666b7 View commit details
    Browse the repository at this point in the history

  5. [#12048] Migrate feedbackSessionPublishedRemindersAction (#12741) 

    * update action logic

* add it for action

* fix checkstyle errors

* fix minor code changes

* fix checkstyles
    @EuniceSim142
    EuniceSim142 authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5d11d27 View commit details
    Browse the repository at this point in the history

  6. Revert "Add config for e2e sql tests (#12762)" (#12765) 

    This reverts commit d7666b7.
    @cedricongjh
    cedricongjh authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c507049 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. [#12048] E2E test migration (#12763) 

    * Create Put and Delete Sql Databundle actions

* deduplicate courses in GetCoursesAction

* add remove and restore sql databundle method to BACKDOOR

* Migrate StudentHomePageE2ETest

* fix architecture tests

* fix tests

* Empty-Commit

* skip sql data bundle checking

* create new class

* fix pmd violation

* Empty-Commit2

* Empty-Commit3
    @cedricongjh
    cedricongjh authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    225d54f View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. [#12048] Add test cases for FeedbackSessionsDb (#12752) 

    * Add test for FeedbackSessionsDb

* update test cases

---------

Co-authored-by: Cedric Ong <[email protected]>
    @dishenggg @cedricongjh
    dishenggg and cedricongjh authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5b3a96f View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. [#12048] Migrate FeedbackSessionOpeningRemindersAction (#12739) 

    * update logic

* update fs logic method

* add it for action

* fix checkstyle errors

* fix checkstyle errors 2

* fix test name typo

* add session-questions association function to it

* minor fixes

* fix checkstyle
    @EuniceSim142
    EuniceSim142 authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    528a67f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into v9-migration

    @weiquu
    weiquu authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    9c53527 View commit details
    Browse the repository at this point in the history

  3. [#12048] Resolve merge conflicts (#12776) 

    * remove extra methods

* remove method

* remove extra check

* fix failing tests

* fix 2/3 tests

* merge in GetFeedbackSessionActionTest from pr12773
    @weiquu
    weiquu authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    b697768 View commit details
    Browse the repository at this point in the history

  4. bump up postgresql version (#12784)

    @weiquu
    weiquu authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    2495ecd View commit details
    Browse the repository at this point in the history

  5. Merge pull request #12771 from TEAMMATES/v9-migration 

    [#12048] Merge in current v9-migration
    @weiquu
    weiquu authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    df49335 View commit details
    Browse the repository at this point in the history

  6. [#12048] Migrate student notification page e2e test (#12773) 

    * Persist ReadNotifications in databundle

* Add remove or replace sql databundle methods into base test case

* Remove unnecessary checking of account migrated

* Migrate StudentNotificationPageE2ETest

* Fix lint issues

* Return sqldatabundle for tests

* Revert changes to NotificationPage to use notification id instead

* Add assertion for readNotifications from account

* fix architectureTest

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    affcc46 View commit details
    Browse the repository at this point in the history

  7. [#12048] Migrate feedbacktextquestion e2e test (#12775) 

    * fix GetFeedbackQuestionsAction bug

* migrate over getEntity and verifyEquals

* migrate FeedbackTextQuestionE2ETesty

* fix lint

* fix lint

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    fdba184 View commit details
    Browse the repository at this point in the history

  8. migrate InstructorCourseJoinConfirmationPageE2ETest (#12790)

    @cedricongjh
    cedricongjh authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    6466d36 View commit details
    Browse the repository at this point in the history

  9. [#12048] Migrate instructor courses page e2e test (#12789) 

    * make courses to be created in datastore

* mirgate InstructorCoursePageE2ETest

* fix lint

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    1d9011f View commit details
    Browse the repository at this point in the history

  10. [#12048] Fix GetSessionResponseStatsActionIT (#12777) 

    * Migrate GetSessionResponseStatsAction

* fix: fix NPE issues

* fix: remove extra comments

* fix: remove extra line

---------

Co-authored-by: Zhang Ziqing <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>
    @domoberzin @ziqing26 @weiquu
    4 people authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7a22ab8 View commit details
    Browse the repository at this point in the history

  11. Fix incorrect usage of recipient as param (#12797)

    @domlimm
    domlimm authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    fc0fbd1 View commit details
    Browse the repository at this point in the history

  12. migrate instructor notif e2e (#12792) 

    Co-authored-by: Cedric Ong <[email protected]>
    @dishenggg @cedricongjh
    dishenggg and cedricongjh authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    8125d53 View commit details
    Browse the repository at this point in the history

  13. [#12048] migrate AdminHomePageE2ETest (#12794) 

    * migrate AdminHomePageE2ETest

* fix lint

---------

Co-authored-by: EuniceSim142 <[email protected]>
    @cedricongjh @EuniceSim142
    cedricongjh and EuniceSim142 authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    bcfc5cb View commit details
    Browse the repository at this point in the history

  14. [#12048] Create IT for GetFeedbackSessionSubmittedGiverSetAction (#12778 

    )

* Migrate GetSessionResponseStatsAction

* fix: fix NPE issues

* feat: add IT for GetFeedbackSessionSubmittedGiverSetAction

* fix: remove extra comment

* fix: remove duplicate method

---------

Co-authored-by: Zhang Ziqing <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>
    @domoberzin @ziqing26 @weiquu
    4 people authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7da77bb View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. shift accounts json (#12802)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    3a21860 View commit details
    Browse the repository at this point in the history

  2. Migrate instructor feedback edit page e2e test (#12795) 

    Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    4230284 View commit details
    Browse the repository at this point in the history

  3. migrate StudentHomePageE2ETest (#12807)

    @cedricongjh
    cedricongjh authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    39534e6 View commit details
    Browse the repository at this point in the history

  4. migrate AdminAccountsPageE2ETest (#12806)

    @cedricongjh
    cedricongjh authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    12e8383 View commit details
    Browse the repository at this point in the history

  5. [#12048] Migrate UpdateStudentAction (#12727) 

    * Modify student entity

* Add update comment logic

* Modify logic files for cascading update and creation for student

* Add database queries for updating student

* Update EnrollStudentsAction

* Fix checkstyle

* Remove extra query for editor update

* Remove email update logic

* Update javadocs

* Copy over logic for Team and Section validation

* Edit javadocs

* Change StudentAttributes to Student instead

* Fix lint issues

* Fix lint issues

* Fix component tests and lint

* Remove ununsed method

* Fix lint

* Update validation logic to use Student

* Update test case

* Add tests for duplicate team across sections

* Migrate UpdateStudentAction and add tests

* Remove resetStudentGoogleId

* Refactor updateStudentCascade

* Fix integration tests

* Fix checkstyle

* Fix integration tests

* Fix lint

* Add persist verification in test

* Fix test

* Fix tests

* Remove unused method

* Fix test

* Fix test

* Fix test

* Split UpdateStudentActionIT into multiple testcases

* Add test separators

---------

Co-authored-by: Dominic Berzin <[email protected]>
Co-authored-by: domoberzin <[email protected]>
    @marquestye @domoberzin
    3 people authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    3191fd1 View commit details
    Browse the repository at this point in the history

  6. Add locale for java datetime formatter (#12826) 

    Co-authored-by: YX Z <[email protected]>
    @yuanxi1
    yuanxi1 and YX Z authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    a913315 View commit details
    Browse the repository at this point in the history

  7. [#12048] Move accounts JSON for FeedbackConstSumOptionQuestionE2ETest (… 

    …#12804)

* shift accounts json

* update json

* lint
    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    b8c9968 View commit details
    Browse the repository at this point in the history

  8. fix failing component tests (#12837)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    a77674f View commit details
    Browse the repository at this point in the history

  9. [#12048] Move accounts JSON for FeedbackConstSumRecipientQuestionE2ET… 

    …est (#12805)

* accounts json

* update json

* lint
    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    36cf624 View commit details
    Browse the repository at this point in the history

  10. [#12048] Move accounts JSON for FeedbackContributionQuestionE2ETest (#… 

    …12808)

* account json

* lint
    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    268253e View commit details
    Browse the repository at this point in the history

  11. accounts json (#12809)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    0fad16b View commit details
    Browse the repository at this point in the history

  12. accounts json (#12810)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    d5c5ee8 View commit details
    Browse the repository at this point in the history

  13. accounts json (#12812)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6464b97 View commit details
    Browse the repository at this point in the history

  14. accounts json (#12816)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6559bbc View commit details
    Browse the repository at this point in the history

  15. accounts json (#12817)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1c18ddb View commit details
    Browse the repository at this point in the history

  16. [#12048] Migrate account for StudentCourseDetailsPageE2ETest (#12818) 

    * migrate account

* fix eof line
    @EuniceSim142
    EuniceSim142 authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c5bb4ee View commit details
    Browse the repository at this point in the history

  17. accounts json (#12819)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    d653637 View commit details
    Browse the repository at this point in the history

  18. accounts json (#12821)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    7256d14 View commit details
    Browse the repository at this point in the history

  19. accounts json (#12825)

    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    783eb3d View commit details
    Browse the repository at this point in the history

  20. [#12048] Move accounts JSON for FeedbackRankOptionQuestionE2ETest (#1… 

    …2813)

* accounts json

* lint
    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    c86a8f1 View commit details
    Browse the repository at this point in the history

  21. [#12048] Move accounts JSON for FeedbackRankRecipientQuestionE2ETest (#… 

    …12814)

* accounts json

* lint
    @weiquu
    weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    9bd8c2b View commit details
    Browse the repository at this point in the history

  22. [#12048] Move accounts JSON for InstructorStudentRecordsPageE2ETest (#… 

    …12822)

* migrate tests

* fix lint

---------

Co-authored-by: Wei Qing <[email protected]>
    @EuniceSim142 @weiquu
    EuniceSim142 and weiquu authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    e49baf0 View commit details
    Browse the repository at this point in the history

  23. [#12048] Revert createaccountaction (#12835) 

    * revert CreateAccountAction

* Ignore tests

* change import for ignore annotation to testng
    @cedricongjh
    cedricongjh authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    cbcab99 View commit details
    Browse the repository at this point in the history

  24. [#12048] Migrate Admin Notifications E2E Test (#12793) 

    * feat: add resources for admin notifications e2e test

* fix: set created at on notification creation

* feat: migrate admin notifications e2e test

* fix: remove created at check for notifications

* fix: remove extra comments

* fix: remove explicit created at

* fix: null check for created at

* fix lint

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @domoberzin @cedricongjh
    3 people authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    500e742 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. [#12048] Move accounts JSON for AutomatedSessionRemindersE2ETest (#12803 

    )

* shift accounts json

* revert formatting changes

* Update src/e2e/resources/data/AutomatedSessionRemindersE2ETest_SqlEntities.json

Co-authored-by: EuniceSim142 <[email protected]>

* change testData to sqlTestData

---------

Co-authored-by: EuniceSim142 <[email protected]>
    @weiquu @EuniceSim142
    weiquu and EuniceSim142 authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    e9cdd63 View commit details
    Browse the repository at this point in the history

  2. [#12048] Move accounts JSON for InstructorCourseDetailsPageE2ETest (#… 

    …12823)

* accounts json

* lint

---------

Co-authored-by: Cedric Ong <[email protected]>
    @weiquu @cedricongjh
    weiquu and cedricongjh authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f59f75b View commit details
    Browse the repository at this point in the history

  3. [#12048] Move accounts JSON for InstructorCourseEnrollPageE2ETest (#1… 

    …2827)

* accounts json

* lint
    @weiquu
    weiquu authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    398d2cf View commit details
    Browse the repository at this point in the history

  4. [#12048] Move accounts JSON for InstructorCourseStudentDetailsEditPag… 

    …eE2ETest (#12829)

* accounts json

* lint
    @weiquu
    weiquu authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    455a564 View commit details
    Browse the repository at this point in the history

  5. [#12048] Move accounts JSON for InstructorCourseStudentDetailsPageE2E… 

    …Test (#12831)

* accounts sjon

* lint
    @weiquu
    weiquu authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6c2dfa2 View commit details
    Browse the repository at this point in the history

  6. [#12048] Move accounts JSON for InstructorFeedbackReportPageE2ETest (#… 

    …12833)

* accounts json

* lint
    @weiquu
    weiquu authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1376426 View commit details
    Browse the repository at this point in the history

  7. [#12048] Move accounts JSON for InstructorSessionIndividualExtensionP… 

    …ageE2ETest (#12832)

* migrate accounts

* fix lint

---------

Co-authored-by: Dominic Lim <[email protected]>
    @EuniceSim142 @domlimm
    EuniceSim142 and domlimm authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    914c552 View commit details
    Browse the repository at this point in the history

  8. migrate accounts (#12834) 

    Co-authored-by: Dominic Lim <[email protected]>
    @EuniceSim142 @domlimm
    EuniceSim142 and domlimm authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    bac2a64 View commit details
    Browse the repository at this point in the history

  9. [#12048] Move accounts JSON for InstructorStudentListPageE2ETest (#12830 

    )

* migrate accounts

* fix eof line

---------

Co-authored-by: Dominic Lim <[email protected]>
    @EuniceSim142 @domlimm
    EuniceSim142 and domlimm authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    21cb04a View commit details
    Browse the repository at this point in the history

  10. [#12048] Migrate AdminSearchPageE2ETest (#12838) 

    * migate admin search e2e

* fix e2e test

* fix failing tests

* fix: add put sql document methods

* fix: add migrated check back in

* fix: add cleanup method

* fix: add search document removal for account request

* fix lint and tests

* fix: json file formatting

* fix: init both searchManagers

* fix: add comments

* fix: remove notifications field in data file

---------

Co-authored-by: Wei Qing <[email protected]>
    @domoberzin @weiquu
    domoberzin and weiquu authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    203ec24 View commit details
    Browse the repository at this point in the history

  11. [#12048] fix InstructorHomePageE2ETest (#12839) 

    * fix InstructorHomePageE2ETest

* fix automated session reminders json
    @cedricongjh
    cedricongjh authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5e2e2a6 View commit details
    Browse the repository at this point in the history

  12. [#12048] Migrate Notification Banner E2E (#12840) 

    * Add locale for java datetime formatter

* Migrate non-course content for NotificationBannerE2ETest

* Fix linting

* Fix snapshot test

---------

Co-authored-by: YX Z <[email protected]>
Co-authored-by: YX Z <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @yuanxi1 @cedricongjh
    4 people authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7b2a69c View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. [#12048] Migrate GetSessionResultsAction (#12719) 

    * Migrate SessionResultsData

* Add default entities

* Add helper methods to assist migrated logic

* Migrate buildCompleteGiverRecipientMap

* Migrate checkSpecificAccessControl

* Add default team instance for instructor

* Migrate session results data logic

* Use default team entity for instructor instead of const

* Migrate non-db logic

* Refactor Datastore and SQL action logic out to separate methods

* Fix checkstyle errors

* Migrate DB logic

* Fix checkstyle errors

* Move default instructor team entity to const

* Add test for SqlSessionResultsBundle

* Fix SQL results bundle test

* Add IT for GetSessionResultsAction

* Fix action logic

* Fix checkstyle errors

* Remove unused method parameters

* Fix persistence issues in test cases

* Remove question getter for comment

* Rename boolean methods to start with verb

* Reword comment to clarify question ID

* Refactor getting question UUID from param value

* Remove unneeded getters

* Remove entities from Const

* Revert changes to SqlCourseRoster

* Create and use missing response class

* Refactor no response text to const

* Migrate preview-related functionality

* Migrate preview functionality for question output

* Fix recipient section filter

* Update test cases to handle question preview

* Merge duplicate methods

* Fix checkstyle errors

* Add missing questions with non-visible preview responses

* Remove outdated test

* Edit for style and readability

* Fix missing join

* Fix section filtering logic

* Fix checkstyle errors
    @xenosf
    xenosf authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2dad48b View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. [#12783] Fix GitHub actions (#12850) 

    * add sql workflow

* specify directory for hashfiles

* update github actions branches
    @cedricongjh
    cedricongjh authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    30ac90b View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. [#12588] Add tests for student list component (#12854) 

    * add student to generic builder

* add tests to student list

* remove unused getAriaSort from student list

* fix lint

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    0ed34c9 View commit details
    Browse the repository at this point in the history

  2. [#12048] SQL injection test for UsersDbIT (#12851) 

    * Add SQL injection tests for usersDb

* change name of team

* fix tests and add missing test

* fix pmd issue
    @cedricongjh
    cedricongjh authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    c87457c View commit details
    Browse the repository at this point in the history

  3. [#12859] create utility to test event emitters (#12860) 

    * create utility to test event emitters

* fix lint issues
    @cedricongjh
    cedricongjh authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    4563dc4 View commit details
    Browse the repository at this point in the history

  4. [#12048] Add SQL injection tests in NotificationDbIT (#12858) 

    * Add SQL injection tests for createNotification

* Fix lint

---------

Co-authored-by: Cedric Ong <[email protected]>
    @jayasting98 @cedricongjh
    jayasting98 and cedricongjh authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    36c2b32 View commit details
    Browse the repository at this point in the history

  5. fix gatekeeper logic (#12855)

    @cedricongjh
    cedricongjh authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    123d2f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. [#12048] Add tests for CourseDbIT (#12786) 

    * feat: add more coverage for methods in CoursesDb

* fix: add further test cases

---------

Co-authored-by: Dominic Lim <[email protected]>
    @domoberzin @domlimm
    domoberzin and domlimm authored Mar 3, 2024
    Configuration menu
    Copy the full SHA
    0f9d990 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. [#12048] SQL injection test for AccountRequestsDbIT (#12788) 

    * sql injection test

* Update src/it/java/teammates/it/storage/sqlapi/AccountRequestsDbIT.java

Co-authored-by: EuniceSim142 <[email protected]>

* change database name

* fix lint

* rewrite email sql

* fix lint

* add tests for other methods

---------

Co-authored-by: EuniceSim142 <[email protected]>
Co-authored-by: Kevin Foong <[email protected]>
    @weiquu @EuniceSim142 @kevin9foong
    3 people authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    648d606 View commit details
    Browse the repository at this point in the history

  2. [#12048] SQL injection test for AccountsDbIT (#12800) 

    * sql injection tests for accountsdb

* lint

* lint

---------

Co-authored-by: EuniceSim142 <[email protected]>
    @weiquu @EuniceSim142
    weiquu and EuniceSim142 authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    40bb202 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. [#12588] Add unit tests for sessions table (#12863) 

    * add tests for resend-results-link-to-respondent-modal-component

* add tests to respondent-list-info-table

* add unit tests for send-reminders-to-respondents-modal

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @ziqing26
    cedricongjh and ziqing26 authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e7e7d49 View commit details
    Browse the repository at this point in the history

  2. [#12048] Migrate GetFeedbackSessionLogsAction (#12862) 

    * migrate getfeedbacksessionlogsaction

* fix lint

* fix lint

---------

Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>
    @weiquu @domlimm @ziqing26
    3 people authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    cad9954 View commit details
    Browse the repository at this point in the history

  3. [#12048] SQL injection test for CoursesDbIT (#12801) 

    * security tests for coursesdb

* lint

* standardise section-name and team-name

* fix lint
    @weiquu
    weiquu authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a8ca0cf View commit details
    Browse the repository at this point in the history

  4. [#12048] SQL Injection Test for FeedbackResponsesDb (#12848) 

    * add sqli tests 1

* add sqli tests 2

* fix checkstyle

---------

Co-authored-by: Wei Qing <[email protected]>
    @EuniceSim142 @weiquu
    EuniceSim142 and weiquu authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    97f19cb View commit details
    Browse the repository at this point in the history

  5. [#12048] SQL Injection tests for FeedbackResponseCommentsDbIT (#12853) 

    * add sqli tests

* fix checkstyle

---------

Co-authored-by: Wei Qing <[email protected]>
    @EuniceSim142 @weiquu
    EuniceSim142 and weiquu authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e3da52f View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. [#12048] Migrate StudentCourseJoinConfirmationPageE2ETest (#12815) 

    * migrate test

* Update src/e2e/java/teammates/e2e/cases/StudentCourseJoinConfirmationPageE2ETest.java

Co-authored-by: Cedric Ong <[email protected]>

---------

Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @EuniceSim142 @weiquu @cedricongjh
    3 people authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b0a8caf View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Add check for sql tests in TestNgXml (#12870)

    @cedricongjh
    cedricongjh authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3e254b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Add testcases for FeedbackResponseCommentsLogicTest (#12769) 

    * Added testcase

* Add new testcases

* Remove dead store

---------

Co-authored-by: Wei Qing <[email protected]>
    @mingyuanc @weiquu
    mingyuanc and weiquu authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    ef31826 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. [#12048] Fix account creation (#12871) 

    * use sqllogic for accounts

* fix tests

* Fix bug where read notis not deleted when noti deleted

* Fix lint

* fix GetFeedbackSessionsAction

* Add cascade delete for read notification in account

* revert feedbackresponsecomment logic

* disabled tests and fix lint

* fix failing test

---------

Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @domlimm @ziqing26
    3 people authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    bed1adf View commit details
    Browse the repository at this point in the history

  2. [#12048] Add tests for FeedbackQuestionsDb (#12759) 

    * Add verification during feedback question creation

* Add tests for FeedbackQuestionsDb

* Fix missing javadocs

* Fix feedback question creation logic

* Add test

* Reuse error message

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>
    @marquestye @cedricongjh @ziqing26
    3 people authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    bf5a2ac View commit details
    Browse the repository at this point in the history

  3. [#12048] Create Non Course Data Migration Script (#12785) 

    * Add seed script

* [#12048] Add DataMigrationEntitiesBaseScriptSql and DataMigrationForAccountSql (#12766)

* Add hibernate connection

* Add DataMigrationEntitiesBaseScriptSql and example Account Migration

* [#12048] Add verify to seed db (#12767)

* Add verify

* Revert secrets

* Clean up seed script (#12768)

* Fix account migration script

* Add client property

* Add SQL notification migration script

* Modify seed script to persist to local database store

* Data migration for account

* Add seed data for data migration

* Add Account and Read Notification

* Remove comments

* [#12048] Add migration script for Usage Statistics (#12798)

* Add migration script for UsageStatistics

* Add seed script for usage statistics and add ofy support

* Set preview to true by default

* [#12048] Add migration script for Account Request (#12799)

* Add migration script for acc req

* Update migration script

* Add checks to notification script (#12836)

* Add checks to notification script

* Fix comments

* Create script to verify row count for non-course entities (#12824)

* Create script to verify row count

* Add read notification verification

* Add comment

* Add base script for verifying migrated attributes (#12841)

* Add datastore entity comparison function (except readNotification)

* Add verify attribute entity base script

Co-authored-by: Kevin Foong <[email protected]>

* Add verify usage statistics

* Add verification script for account request

* Amend base script to fetch lazily loaded keys

* Fix migration verification for notification

* Add migration verification script for account

* Save progress

* Add changes

* Fix bug

* Add changes

* Add support for pagination

* Add changes (#12846)

* Add a script to remove datastore non course entities and fix progress bar in seeddb

* Add warning for the script

* Add user check for removal script

* Revert remove script

* fix seed script to populate notification UUID correctly

* Remove unnecessary whitespace

* Add connection verification script

* Remove only one entity in Verify Connection Script

* Fix seeding of data for data migration (#12873)

* Fix notification and readNotification from having different endtime

* Fix seed data to create notification to nearest millisecond

* Remove commented out println

* Uncomment databundle persistance

* Remove unnecessary comments and fix format

* Revert logs in EntitesDb

* V9 Migration: Fix verification pagination, improve logging (#12874)

* Fix numPages division bug, add logging, testing paging

* Add logging

* Remove unnecessary function

* Remove unnecessary files, shift some functions

* Clean up branch

* Fix lint errors

* Fix lint errors v2

* Fix lint errors v3

* Fix spotBugsTest

---------

Co-authored-by: Nicolas Chang <[email protected]>
Co-authored-by: FergusMok <[email protected]>
Co-authored-by: Kevin Foong <[email protected]>
Co-authored-by: Kevin Foong <[email protected]>
Co-authored-by: Kevin Foong <[email protected]>
    @ziqing26 @NicolasCwy
    @FergusMok @kevin9foong
    6 people authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    b17258b View commit details
    Browse the repository at this point in the history

  4. [#12782] Fix Axe tests, remove e2e-cross (#12878) 

    * Fix all failing CI tests

* Remove e2e-cross

---------

Co-authored-by: Wei Qing <[email protected]>
    @wkurniawan07 @weiquu
    wkurniawan07 and weiquu authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    0446575 View commit details
    Browse the repository at this point in the history

  5. [#12876] Release V9.0.0-beta.0 (#12879)

    @ziqing26
    ziqing26 authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    67404f3 View commit details
    Browse the repository at this point in the history

  6. [#12048] Change title and message field for notification to "TEXT" (#… 

    …12880)
    @NicolasCwy
    NicolasCwy authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    b48dabb View commit details
    Browse the repository at this point in the history

  7. [#12048] Revert column type for notification title (#12881)

    @ziqing26
    ziqing26 authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    e5e8fbd View commit details
    Browse the repository at this point in the history

  8. [#12048] Prepare Patch Data Migration Script for Account (#12883) 

    * Set isMigrated flag for Account

* Add patch update
    @ziqing26
    ziqing26 authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    2caea93 View commit details
    Browse the repository at this point in the history

  9. [#12048] Patch account and read notification migration (#12884) 

    * Add a separate script for patching

* Separate patch script from the first run script

* Revert separated script
    @ziqing26
    ziqing26 authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    9043ae4 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Enable CI on account request form branch

    @ziqing26 @jayasting98
    ziqing26 authored and jayasting98 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    186a97a View commit details
    Browse the repository at this point in the history

  2. Revert getFilterQuery for account migration (#12887)

    @ziqing26
    ziqing26 authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7668295 View commit details
    Browse the repository at this point in the history

  3. [#12588] Add unit tests for visibility panel (#12868) 

    * add unit tests for three functions in visibility-panel component

* add unit tests for modifyVisibilityControl in visibility-panel component

* fix typo for initialized

* add test for disallowing visibility when visibility is initially allowed

* refactor test strings

* remove extra describes

* add test for when visibility is already true and isAllowed is true

* optimize the number of modifyVisibilityControl calls

* remove unneeded FeedbackVisibilityType from test variables

* change const boolean to hard coded

* refactor jest spy naming

* fix linting issues

* remove unneeded spaces in test strings

* simplify tests

* fix formatting inconsistencies

* remove unneeded modifyVisibilityControl calls

---------

Co-authored-by: Wei Qing <[email protected]>
    @Andy-W-Developer @weiquu
    Andy-W-Developer and weiquu authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d32c2cb View commit details
    Browse the repository at this point in the history

  4. [#12048] Add verification migration script (#12890) 

    * Fix progress counter not incrementing
* Separate migration from verification script
    @NicolasCwy
    NicolasCwy authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    3e1718c View commit details
    Browse the repository at this point in the history

  5. [#12048] Fix get feedback sessions action (#12886) 

    * fix getFeedbackSessionsAction to support dual DB

* enable GetFeedbackSessionsAction test

* change verify course panel to search all panels rather than assume ordering

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @ziqing26
    cedricongjh and ziqing26 authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e385eed View commit details
    Browse the repository at this point in the history

  6. [#12048] Add tests for FeedbackQuestionsDbIT (#12781) 

    * Add verification during feedback question creation

* Add tests for FeedbackQuestionsDb

* Fix missing javadocs

* Fix feedback question creation logic

* Add test

* Reuse error message

* Add tests for FeedbackQuestionsDbIT

---------

Co-authored-by: marquestye <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @dishenggg @marquestye
    @weiquu @cedricongjh
    4 people authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2ad2242 View commit details
    Browse the repository at this point in the history

  7. [#12048] Add integration tests for FeedbackResponseCommentsDb (#12849) 

    * Migrate SessionResultsData

* Add default entities

* Add helper methods to assist migrated logic

* Migrate buildCompleteGiverRecipientMap

* Migrate checkSpecificAccessControl

* Add default team instance for instructor

* Migrate session results data logic

* Use default team entity for instructor instead of const

* Migrate non-db logic

* Refactor Datastore and SQL action logic out to separate methods

* Fix checkstyle errors

* Migrate DB logic

* Fix checkstyle errors

* Move default instructor team entity to const

* Add test for SqlSessionResultsBundle

* Fix SQL results bundle test

* Add IT for GetSessionResultsAction

* Fix action logic

* Fix checkstyle errors

* Remove unused method parameters

* Fix persistence issues in test cases

* Remove question getter for comment

* Rename boolean methods to start with verb

* Reword comment to clarify question ID

* Refactor getting question UUID from param value

* Remove unneeded getters

* Remove entities from Const

* Revert changes to SqlCourseRoster

* Create and use missing response class

* Refactor no response text to const

* Migrate preview-related functionality

* Migrate preview functionality for question output

* Fix recipient section filter

* Update test cases to handle question preview

* Merge duplicate methods

* Fix checkstyle errors

* Add missing questions with non-visible preview responses

* Remove outdated test

* Edit for style and readability

* Fix missing join

* Fix section filtering logic

* Fix checkstyle errors

* Add integration tests

* Refactor tests for readability

* Fix broken test cases

* Rename test section key

* Use separate json bundle for test data

* Clear session when set up

---------

Co-authored-by: Cedric Ong <[email protected]>
    @xenosf @cedricongjh
    xenosf and cedricongjh authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b802335 View commit details
    Browse the repository at this point in the history

  8. [#12588] Improve test code coverage of QuestionResponsePanelComponent (… 

    …#12867)

* Finish improving the test

* Remove unnecessary file

* Add tested method in test string

---------

Co-authored-by: Leyan Guan <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @leyguan @cedricongjh
    3 people authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8722e51 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. [#12048] Migrate InstructorSearchPageE2ETest (#12891) 

    * feat: migrate instructor search page e2e test

* fix: add new line

* fix axe test

* remove extra whitespace
    @domoberzin
    domoberzin authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ccdb6cc View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. [#12048] Add integration tests for FeedbackResponsesDb (#12856) 

    * Migrate SessionResultsData

* Add default entities

* Add helper methods to assist migrated logic

* Migrate buildCompleteGiverRecipientMap

* Migrate checkSpecificAccessControl

* Add default team instance for instructor

* Migrate session results data logic

* Use default team entity for instructor instead of const

* Migrate non-db logic

* Refactor Datastore and SQL action logic out to separate methods

* Fix checkstyle errors

* Migrate DB logic

* Fix checkstyle errors

* Move default instructor team entity to const

* Add test for SqlSessionResultsBundle

* Fix SQL results bundle test

* Add IT for GetSessionResultsAction

* Fix action logic

* Fix checkstyle errors

* Remove unused method parameters

* Fix persistence issues in test cases

* Remove question getter for comment

* Rename boolean methods to start with verb

* Reword comment to clarify question ID

* Refactor getting question UUID from param value

* Remove unneeded getters

* Remove entities from Const

* Revert changes to SqlCourseRoster

* Create and use missing response class

* Refactor no response text to const

* Migrate preview-related functionality

* Migrate preview functionality for question output

* Fix recipient section filter

* Update test cases to handle question preview

* Merge duplicate methods

* Fix checkstyle errors

* Add missing questions with non-visible preview responses

* Remove outdated test

* Edit for style and readability

* Fix missing join

* Fix section filtering logic

* Fix checkstyle errors

* Add integration tests

* Update and use typical bundle

* Update test cases for updated bundle

* Revert typical data bundle

* Use separate data bundle for feedback responses test

* Revert unrelated tests

* Fix json formatting

---------

Co-authored-by: Cedric Ong <[email protected]>
    @xenosf @cedricongjh
    xenosf and cedricongjh authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    931dea4 View commit details
    Browse the repository at this point in the history

  2. [#12048] V9 migration and verification script optimization (#12896) 

    * Add changes

* Add changes for migration

* Revert the illegals

* Linting

* Add additional batching

* Add notes

* Fix linting errors

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @FergusMok @ziqing26
    FergusMok and ziqing26 authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2342189 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. [#12271] Docs: Upgrade to latest MarkBind version (#12893) 

    * Upgrade layouts

* Add breadcrumb for pages

* Fix puml diagrams

* Make navbar sticky

* Upgrade markbind version

* Upgrade markbind

* Upgrade markbind version

* Update pages

* Revert "Upgrade markbind version"

This reverts commit 76b2d44.

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @jingting1412 @ziqing26
    jingting1412 and ziqing26 authored Mar 16, 2024
    Configuration menu
    Copy the full SHA
    2d10806 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. [#11843] Create FeedbackSessionLog entity and cron job action (#12895) 

    * Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs
    @dishenggg
    dishenggg authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    17866eb View commit details
    Browse the repository at this point in the history

  2. add unit test to rubric-question-edit-details-form (#12907)

    @cedricongjh
    cedricongjh authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    da601bd View commit details
    Browse the repository at this point in the history

  3. [#12048] Add SQL injection tests in FeedbackSessionsDbIT (#12857) 

    * Add createTypicalXyz methods

* Add SQL injection tests for createFeedbackSession

* Add SQL injection tests for getFeedbackSession(String, String)

* Add SQL injection tests for getSoftDeletedFeedbackSession

* Add SQL injection test for getSoftDeletedFeedbackSessionsForCourse

* Add SQL injection tests from restoreDeletedFeedbackSession

* Change SQL injection for restoreDeletedFeedbackSession

* Add SQL injection test for getFeedbackSessionEntitiesForCourse

* Add SQL injection test for get ... for course starting after

* Add comment for SQL injection attempts on deleteFeedbackSession

* Add SQL injection tests for updateFeedbackSession

* Add SQL injection tests for softDeleteFeedbackSession

* Fix lint

* Fix PMD

* Make SQL injection query more concise

---------

Co-authored-by: Wei Qing <[email protected]>
    @jayasting98 @weiquu
    jayasting98 and weiquu authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ffb07dd View commit details
    Browse the repository at this point in the history

  4. [#12048] V9 migration verification script optimisation - fetch ReadNo… 

    …tifications for account comparison (#12905)

* Eager load readNotifications for accounts when verifying

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @NicolasCwy @ziqing26
    NicolasCwy and ziqing26 authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    868982f View commit details
    Browse the repository at this point in the history

  5. [#12048] Patch Usage Statistics Migration (#12889) 

    * Patch Usage Statistics

* Add fix

* Remove static

* Fix bug for createdAt

---------

Co-authored-by: FergusMok <[email protected]>
    @ziqing26 @FergusMok
    ziqing26 and FergusMok authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2eedf1d View commit details
    Browse the repository at this point in the history

  6. [#12048] Add deep comparison for entities in verifyEquals for E2E (#… 

    …12892)

* Add base for verifyEquals for all entities

* Remove branches with missing EntityData class

* Add comparison for response details JSON string

* Fix lint errors

* Fix lint errors

* Update method to compare feedbackquestion and response details by JSON string
    @domlimm
    domlimm authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ddd6f09 View commit details
    Browse the repository at this point in the history

  7. [#12048] Migrate InstructorNotificationsPageE2E (#12906) 

    * Migrate InstructorNotificationsPageE2E

* Fix unsaved transient entity error

* Fix lint

* Fix lint

* Update testng xml

---------

Co-authored-by: YX Z <[email protected]>
Co-authored-by: YX Z <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @yuanxi1 @weiquu @cedricongjh
    5 people authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a34c3c5 View commit details
    Browse the repository at this point in the history

  8. [#11878] Remove AccountRequest unique constraint (#12899) 

    * Remove AccountRequest unique constraint

* Remove EntityAlreadyExistsException from the throws clause

* Remove unused import of EntityAlreadyExistsException

* Fix failing checks

* Remove EntityAlreadyExistsException in dependents

* Remove assertion that is now incorrect

* Remove mysterious trailing whitespaces that appeared out of nowhere

* Remove parts in E2E test that are no longer relevant

* Remove unused import

* Improve clarity of test case

Co-authored-by: EuniceSim142 <[email protected]>

---------

Co-authored-by: EuniceSim142 <[email protected]>
    @jayasting98 @EuniceSim142
    jayasting98 and EuniceSim142 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    395bdd7 View commit details
    Browse the repository at this point in the history

  9. [#11878] Add status and comments to AccountRequest (#12898) 

    * Add AccountRequestStatus

* Add AccountRequest status attribute

* Add status to AccountRequest constructor

* Add AccountRequest comments attribute

* Add comments to AccountRequest constructor

* Wrap lines

* Remove mysterious unnecessary imports that appeared out of nowhere

* Use non-null placeholder

* Use literal placeholder
    @jayasting98
    jayasting98 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    fc1342f View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. [#12048] Migrate FeedbackMsqQuestionE2ETest (#12904) 

    * Migrate test

* Update test

* Update sql json

* fix lint

* Fix lint

* Update json and add test to xml

* Revert "Fix lint"

This reverts commit f767b52.

* Revert "Update sql json"

This reverts commit 4574475.

* Fix xml

* Change to use makeDeepCopy

* sort questions

* fix verifyEquals method

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @dishenggg @cedricongjh
    3 people authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4dc0c6d View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Add account request search indexing (#12923)

    @jayasting98
    jayasting98 authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d4ebcda View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Update chrome driver download link in e2e-testing.md (#12924)

    @nadasuhailAyesh12
    nadasuhailAyesh12 authored Mar 23, 2024
    Configuration menu
    Copy the full SHA
    9a099c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. [#12048] Add SQL configuration into build.properties and build-dev.pr… 

    …operties (#12917)

* Add production config

* Remove forgotten host and password

* Fix lint

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @FergusMok @ziqing26
    FergusMok and ziqing26 authored Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e0c6a2d View commit details
    Browse the repository at this point in the history

  2. [#12048] Add SQL description for postgres config (#12931) 

    * Add production config

* Remove forgotten host and password

* Fix lint

* Address changes, include production_user

* Linting
    @FergusMok
    FergusMok authored Mar 24, 2024
    Configuration menu
    Copy the full SHA
    845009e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. [#11878] Add new account request alert email for admins (#12926) 

    * Add admin alert email

* Add email type

* Add subject

* Add email content

* Indicate that action is needed in the email subject
    @jayasting98
    jayasting98 authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    24a914d View commit details
    Browse the repository at this point in the history

  2. [#12588] Improve test code coverage of core components - ToastCompone… 

    …nt (#12916)

* add test cases

* add test case for isTemplate()

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>
    @techMedMau @cedricongjh @domlimm
    3 people authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    3499d2a View commit details
    Browse the repository at this point in the history

  3. [#12588] Add unit tests to question edit answer form (#12935) 

    * add unit tests to constsum-options-question-edit-answer-form

* add unit tests to constsum-options-question-edit-answer-form

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @ziqing26
    cedricongjh and ziqing26 authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7ba20fc View commit details
    Browse the repository at this point in the history

  4. [#11878] Add GetAllPendingAccountRequests API (#12927) 

    * add endpoint

* remove 'all' in class and method names

* fix checkstyle

* add it test

* fix checkstyle

* fix checkstyle

* fix failing test

* update endpoint url

* update it tests

* fix linting

* update param name

* update request param condition
    @EuniceSim142
    EuniceSim142 authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    126d2c4 View commit details
    Browse the repository at this point in the history

  5. [#11878] Modify CreateAccountRequestAction (#12913) 

    * Add AccountCreateRequest instructorComments attribute

* Add new AccountRequestData attributes

* Remove check for registered instructor

* Remove sending of registration email

* Use AccountCreateRequest comments

* Change output of CreateAccountRequestAction to AccountRequestData

* Add CreateAccountRequestActionIT

* Test execute with null arguments

* Test execute with valid requests

* Test execute on invalid arguments

* Allow anybody to create an account request

* Fix architecture test

* Fix test

* Update tests to verify search indexing
    @jayasting98
    jayasting98 authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    cb29108 View commit details
    Browse the repository at this point in the history

  6. add delay to task queuer for indexing account request (#12936) 

    Co-authored-by: Nicolas <[email protected]>
    @cedricongjh @NicolasCwy
    cedricongjh and NicolasCwy authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    1be2adb View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Make account req data migration script rerunnable (#12932)

    @ziqing26
    ziqing26 authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    716fdc4 View commit details
    Browse the repository at this point in the history

  2. [#12048] Relax read notif verification for migration verification scr… 

    …ipt (#12937)

* Fix account requests with wrong field during seed

* Relax account attributes verification

* Fix lint errors

* Fix order of account request variables
    @NicolasCwy
    NicolasCwy authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ca20709 View commit details
    Browse the repository at this point in the history

  3. [#12920] Create script to migrate noSQL test data to SQL schema format ( 

    #12922)

* Add classes to migrate test json data

* Add toposort  script

* Add function to remove foreign key data

* Cleanup

* WIP

* Simplify keys for students and instructors

* Fix lint issues

* Output SQL JSON in same folder as JSON

* Change output file name

* Fix bug: wrong jsonkey used

* Fix lint error

* Make section and team name unique

* Set read notification key to be unique

* Delete python file
    @NicolasCwy
    NicolasCwy authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e435f17 View commit details
    Browse the repository at this point in the history

  4. [#12588] Improve test code coverage of core components - ViewResultsP… 

    …anelComponent (#12918)

* add test cases to ViewResultsPanelComponent

* fix lint errors

---------

Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>
    @techMedMau @domlimm @ziqing26
    3 people authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a02f444 View commit details
    Browse the repository at this point in the history

  5. fix resetAccountAction (#12934) 

    Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @ziqing26
    cedricongjh and ziqing26 authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    11b8b81 View commit details
    Browse the repository at this point in the history

  6. [#12048] Migrate Feedback Rank Option E2E test (#12902) 

    * Initial commit

* Fix lint

* Follow convention and add test

* Change file path

* Fix requested changes

* Fixed testcases

* Fix lint

* Add deepcopy

* Fixed e2e test

---------

Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
    @mingyuanc @weiquu @cedricongjh
    3 people authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0cfadef View commit details
    Browse the repository at this point in the history

  7. [#12048] Migrate FeedbackMcqQuestionE2ETest (#12820) 

    * Migrate MCQ E2E

* Fix lint

* Fix lint

* Update xml

---------

Co-authored-by: Cedric Ong <[email protected]>
    @dishenggg @cedricongjh
    dishenggg and cedricongjh authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e51132e View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. [#11878] Upgrade instructor request form UI (#12929) 

    * Add confirmation prompt

* Remove old form iframe

* Improve declaration view spacing

* Edit page heading phrasing for clarity

* Create request form

* Add validation messages

* Fix form validation

* Set up form submission confirmation

* Create submission acknowledgement view

* Fix URL checking regex

* Fix initial state

* Display placeholder when optional field is empty

* Fix code style

* Edit comment for clarity

* Fix institution and country combination

Co-authored-by: Jay Aljelo Ting <[email protected]>

* Fix naming

* Remove hard line break

* Add explanatory comment for regex

* Remove newline

* Add newlines at end of file

* Clear styles file

* Re-add styles file

* Include test

* Add test cases for requestSubmissionEvent

* Improve test case readability

* Edit test case name for clarity

* Add snapshot tests

* Revert "Add snapshot tests"

This reverts commit ec7395d.

* Fix lint errors

* Rename methods to be clearer

* Disable submit button when not ready to submit

---------

Co-authored-by: Jay Aljelo Ting <[email protected]>
    @xenosf @jayasting98
    xenosf and jayasting98 authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f7eaa61 View commit details
    Browse the repository at this point in the history

  2. [#12048] Remove unnecessary loading of datastore entities in Instruct… 

    …orNotificationsPageE2ETest (#12911)

* migrate instructor notif e2e

---------

Co-authored-by: Cedric Ong <[email protected]>
    @dishenggg @cedricongjh
    dishenggg and cedricongjh authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    20df6b6 View commit details
    Browse the repository at this point in the history

  3. [#11878] Update Admin Home Page UI for ARF (#12933) 

    * create component for account request table

* cherry pick admin home page changes

* remove testing code

* fix lint and css issues

* fix admin home page snaps

* update admin home snaps

* remove edit approve and reject components

* modify css

* delete edit and reject modal components

* revert spec file changes

* integrate new types

* fix lint

* use enum for status

* fix lint

* fix css lint

* fix lint

* fix lint

* use enum and remove infinite scroll

* remove approve account request code

* remove extra div

* fix url

* modify comments

* revert extra formatting

* remove plural form and use date pipe

* fix naming

* fix spec file and update institute formatting

* fix lint

* combine institute and country columns
    @domoberzin
    domoberzin authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    40613df View commit details
    Browse the repository at this point in the history

  4. [#12048] Migrate InstructorCourseDetailsPageE2ETest (#12908) 

    * Add teammates.e2e.cases.sql.InstructorCourseDetailsPageE2ETest

* Remove data properly to prevent clashes

* Add SQL data bundle

* Verify loaded details

* Use email address when getting a student row

* Check student links

* Verify the sending of invites

* Verify the reminding of all students to join

* Remove SQL data properly to prevent clashes

* Verify the downloading of the student list

* Implement helper methods for Student

* Add BaseTestCaseWithSqlDatabaseAccess::verifyAbsentInDatabase

* Add to testng-e2e-sql.xml

* Verify the deleting of students

* Verify the deleting of all the students

* Fix lint

* Remove duplicate equality check for students
    @jayasting98
    jayasting98 authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a9423da View commit details
    Browse the repository at this point in the history

  5. [#11878] Admin Search UI Update for ARF (#12945) 

    * update admin search page to use acc req component

* fix selector for e2e test

* fix spec files and imports

* update e2e selector

* fix column numbers
    @domoberzin
    domoberzin authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5618370 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. [#11878] Add methods to get an account request by ID (#12953) 

    * Add facade logic method to get an account request by ID

* Add storage method to get an account request by ID

* Add logic method to get an account request by ID
    @jayasting98
    jayasting98 authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0aa7dfb View commit details
    Browse the repository at this point in the history

  2. [#12588] add unit tests for question submission form (#12897) 

    Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @ziqing26
    cedricongjh and ziqing26 authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    78eee47 View commit details
    Browse the repository at this point in the history

  3. Update developers.json (#12958)

    @cedricongjh
    cedricongjh authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9d0cf37 View commit details
    Browse the repository at this point in the history

  4. [#11843] Create Logic and Db layer for FeedbackSessionLogs (#12914) 

    * Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs

* Create skeleton

* Implement logic and db layer

* fix lint

* Update entity

* Fix tests

* Fix bugs and optimize action

* Prevent courseId from being null

* Update GCP logs to store ids

* Fix tests

* Update action to use reference

* Add some error handling

* Fix tests

* Add ids to api output
    @dishenggg
    dishenggg authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ccad41b View commit details
    Browse the repository at this point in the history

  5. Merge pull request #12960 from TEAMMATES/master (#12961)

    @cedricongjh
    cedricongjh authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c4fe140 View commit details
    Browse the repository at this point in the history

  6. [#11878] Add snapshot tests for instructor request form UI (#12942) 

    * Add snapshot tests

* Change double quotes to single quotes
    @xenosf
    xenosf authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    f6329eb View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. [#11878] Foundation for getting by ID in account request endpoints (#… 

    …12957)

* Add account request ID query parameter

* Add account request ID to related front-end types
    @jayasting98
    jayasting98 authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6049c81 View commit details
    Browse the repository at this point in the history

  2. Get account requests by ID in storage update method (#12955)

    @jayasting98
    jayasting98 authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9f0ca34 View commit details
    Browse the repository at this point in the history

  3. Get an account request by ID in SQL injection tests (#12956)

    @jayasting98
    jayasting98 authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9794b8a View commit details
    Browse the repository at this point in the history

  4. [#12048] Fix account request indexing (#12967) 

    * Add isTransactionNeeded method to Action

* Remove delay from taskqueuer

* Change CreateAccountRequest to handle own transactions
    @cedricongjh
    cedricongjh authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    356c318 View commit details
    Browse the repository at this point in the history

  5. configure agroal connection pool (#12971)

    @cedricongjh
    cedricongjh authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2ee4269 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. [#11878] Create instructor request acknowledgement email (#12944) 

    * Create instructor request acknowledgement email

* Add tests for acknowledgement email

* Fix test cases

* Fix comments in expected email

* Use config support email value in email template

* Fix email recipient

* Fix test expected emails

* Remove trailing space

* Use placeholder for support email

* Sanitize acknowledgement email

* Set acknowledgement email to bcc support
    @xenosf
    xenosf authored Mar 30, 2024
    Configuration menu
    Copy the full SHA
    00b85ce View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. [#11878] Merge master into account-request-form (#12972) 

    * Update chrome driver download link in e2e-testing.md (#12924)

* [#12048] Add SQL configuration into build.properties and build-dev.properties (#12917)

* Add production config

* Remove forgotten host and password

* Fix lint

---------

Co-authored-by: Zhang Ziqing <[email protected]>

* [#12048] Add SQL description for postgres config (#12931)

* Add production config

* Remove forgotten host and password

* Fix lint

* Address changes, include production_user

* Linting

* [#12588] Improve test code coverage of core components - ToastComponent (#12916)

* add test cases

* add test case for isTemplate()

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>

* [#12588] Add unit tests to question edit answer form (#12935)

* add unit tests to constsum-options-question-edit-answer-form

* add unit tests to constsum-options-question-edit-answer-form

---------

Co-authored-by: Zhang Ziqing <[email protected]>

* add delay to task queuer for indexing account request (#12936)

Co-authored-by: Nicolas <[email protected]>

* Make account req data migration script rerunnable (#12932)

* [#12048] Relax read notif verification for migration verification script (#12937)

* Fix account requests with wrong field during seed

* Relax account attributes verification

* Fix lint errors

* Fix order of account request variables

* [#12920] Create script to migrate noSQL test data to SQL schema format (#12922)

* Add classes to migrate test json data

* Add toposort  script

* Add function to remove foreign key data

* Cleanup

* WIP

* Simplify keys for students and instructors

* Fix lint issues

* Output SQL JSON in same folder as JSON

* Change output file name

* Fix bug: wrong jsonkey used

* Fix lint error

* Make section and team name unique

* Set read notification key to be unique

* Delete python file

* [#12588] Improve test code coverage of core components - ViewResultsPanelComponent (#12918)

* add test cases to ViewResultsPanelComponent

* fix lint errors

---------

Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>

* fix resetAccountAction (#12934)

Co-authored-by: Zhang Ziqing <[email protected]>

* [#12048] Migrate Feedback Rank Option E2E test (#12902)

* Initial commit

* Fix lint

* Follow convention and add test

* Change file path

* Fix requested changes

* Fixed testcases

* Fix lint

* Add deepcopy

* Fixed e2e test

---------

Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>

* [#12048] Migrate FeedbackMcqQuestionE2ETest (#12820)

* Migrate MCQ E2E

* Fix lint

* Fix lint

* Update xml

---------

Co-authored-by: Cedric Ong <[email protected]>

* [#12048] Remove unnecessary loading of datastore entities in InstructorNotificationsPageE2ETest (#12911)

* migrate instructor notif e2e

---------

Co-authored-by: Cedric Ong <[email protected]>

* [#12048] Migrate InstructorCourseDetailsPageE2ETest (#12908)

* Add teammates.e2e.cases.sql.InstructorCourseDetailsPageE2ETest

* Remove data properly to prevent clashes

* Add SQL data bundle

* Verify loaded details

* Use email address when getting a student row

* Check student links

* Verify the sending of invites

* Verify the reminding of all students to join

* Remove SQL data properly to prevent clashes

* Verify the downloading of the student list

* Implement helper methods for Student

* Add BaseTestCaseWithSqlDatabaseAccess::verifyAbsentInDatabase

* Add to testng-e2e-sql.xml

* Verify the deleting of students

* Verify the deleting of all the students

* Fix lint

* Remove duplicate equality check for students

* [#12588] add unit tests for question submission form (#12897)

Co-authored-by: Zhang Ziqing <[email protected]>

* Update developers.json (#12958)

* Merge pull request #12960 from TEAMMATES/master (#12961)

* [#12048] Fix account request indexing (#12967)

* Add isTransactionNeeded method to Action

* Remove delay from taskqueuer

* Change CreateAccountRequest to handle own transactions

* configure agroal connection pool (#12971)

* Fix comment style for merge

* Remove unnecessary check for account request

---------

Co-authored-by: Nada Ayesh <[email protected]>
Co-authored-by: FergusMok <[email protected]>
Co-authored-by: Maureen Chang <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Nicolas <[email protected]>
Co-authored-by: Ching Ming Yuan <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: DS <[email protected]>
Co-authored-by: Jay Aljelo Ting <[email protected]>
    @ziqing26 @nadasuhailAyesh12
    @FergusMok @techMedMau @cedricongjh @domlimm @NicolasCwy @mingyuanc @weiquu @dishenggg @jayasting98
    11 people authored Mar 31, 2024
    Configuration menu
    Copy the full SHA
    99eeac7 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. [#11878] Change institute length limit (#12974) 

    * Change institute name max length to 128

* Edit test case for new length limit
    @xenosf
    xenosf authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    7ec74c7 View commit details
    Browse the repository at this point in the history

  2. [#11878] Update SearchAccountRequests endpoint (#12950) 

    * update search document and create-core script

* update it

* modify relevant classes to use id instead of (email, institute)

* remove duplicate method

* fix it tests

* fix failing tests

* remove unnecessary comment
    @EuniceSim142
    EuniceSim142 authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0b07036 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. [#12048] Configure connection pool using hikari (#12978) 

    * Configure hikari

* Remove spacing

* Lint
    @FergusMok
    FergusMok authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    38dbf29 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. [#11878] Integrate instructor request form with API (#12943) 

    * Integrate instructor request form FE with API

* Remove redundant statement

* Move URL regex const to backend const file

* Fix import path

* Move URL regex to FieldValidator

* Add validators to match backend fields

* Add error message box

* Change submit button display when loading

* Combine final action into subscribe

* Add max length validators for institution and country

* Fix lint errors

* Add test cases to test submission

* Add specific error messages for form validation

* Remove home page URL field

* Fix lint errors

* Remove url regex from test

* Update snap

* Clean up test code

* Remove comment about home page URL

* Change canSubmit check to getter

* Fix form submit button not re-enabling on error

* Add name pattern validator to front-end

* Fix snapshot
    @xenosf
    xenosf authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    de3181a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. [#11843] Update GetFeedbackSessionLogsAction to use SQL db (#12938) 

    * Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs

* Create skeleton

* Implement logic and db layer

* fix lint

* Update entity

* Fix tests

* Update action to use fslDb

* Fix tests

* Update DbIT to use databundle

* Fix bugs and optimize action

* Prevent courseId from being null

* Update GCP logs to store ids

* Fix tests

* Update action to use reference

* Add some error handling

* Fix tests

* Add ids to api output

* Fix lint

* Update cron.yaml

* Tidy up code

* Update comments
    @dishenggg
    dishenggg authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a98630d View commit details
    Browse the repository at this point in the history

  2. [#11878] Create Update Account Request Action (#12982) 

    * create update action and IT

* update javadocs

* update tests

* add more tests

* simplify logic

* remove unused string

* fix test

* allow null comments

* add more tests

* use EntityNotFoundException

* cleanup after create account requests test

* remove unncessary check
    @domoberzin
    domoberzin authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5779d2f View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. [#12048] Update liquibase configuration (#12930) 

    * Update gradle config

* Update liquibase config for v9

* Turn off table generate for prod

* Update of changelog file

* Add configuration for generating changelog

* Add schema migration docs

---------

Co-authored-by: FergusMok <[email protected]>
    @NicolasCwy @FergusMok
    NicolasCwy and FergusMok authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    028c953 View commit details
    Browse the repository at this point in the history

  2. [#11878] Fix Account Request Update Search Indexing (#12984) 

    * update account request indexing

* add methods to test access control

* refactoring for transactions
    @domoberzin
    domoberzin authored Apr 6, 2024
    Configuration menu
    Copy the full SHA
    4a54001 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. [#11878] Add Edit and Approve Account Requests functionality (#12975) 

    * add edit and approve functionality

* remove rejection code

* fix snap

* integrate endpoint

* disable approve button for approved requests

* use comments instead of comment

* use searchString instead of searchQuery

* fix snap
    @domoberzin
    domoberzin authored Apr 7, 2024
    Configuration menu
    Copy the full SHA
    62750b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. [#11878] Add AccountRequest Rejection email generator. (#12987) 

    * add rejection-email template and email generator method

* add javadoc for email generator method

* add test

* fix test method names

* fix test method name 2

* fix lint

* add bcc for rejection email
    @EuniceSim142
    EuniceSim142 authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    96e5abd View commit details
    Browse the repository at this point in the history

  2. [#12048] Migrate AccountRequestsLogicTest (#12780) 

    * Migrate test cases for AccountRequestsLogic

* Remove test case

* Split test cases
    @xenosf
    xenosf authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1e9ccb0 View commit details
    Browse the repository at this point in the history

  3. [#12048] Migrate AdminSearchPageE2ETest SQL (#12811) 

    * test e2e changes

* fix: reduce e2e test json file size

* fix student key

* fix course key

* fix instructor keys

* fix filepath

* fix e2e test

* remove extra data from bundle

* Add correct removal logic to avoid constraint violation

* Fix e2e tests and lint

fix reset google id test

fix e2e tests

fix e2e tests

fix tests

remove double click

fix unknown symbol

add toast check

change toast verification message

remove toast check

* fix: add null check

* move admin search page e2e test to sql cases

* Rename AdminSearchPageE2ETest_SQLEntities.json to AdminSearchPageE2ETest_SqlEntities.json

* fix failing test

* fix: remove extra null check

* fix: add test to e2e sql xml file

* fix function call

* remove unnecessary changes

* create new file for sql entities

* revert unnecessary changes

* remove trailing whitespace

* add teardown for account requests

---------

Co-authored-by: Cedric Ong <[email protected]>
    @domoberzin @cedricongjh
    domoberzin and cedricongjh authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    84ed244 View commit details
    Browse the repository at this point in the history

  4. [#12995] Create documentation for unit tests (#12996) 

    * Create documentation for unit tests

* Update docs/unit-testing.md

Co-authored-by: Zhang Ziqing <[email protected]>

* Update docs/unit-testing.md

Co-authored-by: Zhang Ziqing <[email protected]>

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @ziqing26
    cedricongjh and ziqing26 authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    db0fd94 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. [#11878] Create reject account request endpoint (#12985) 

    * Create account request rejection endpoint

* Add validation

* Add check for already rejected request when sending email

* Add integration test cases

* Set request method to post

* Fix lint errors

* Update tests list

* Update validation check

* Add test for validation

* Fix lint errors

* Fix validation comparison

* Fix error message test

* Add email sending

* Update test cases

* Refactor reason check code for clarity
    @xenosf
    xenosf authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    fb0ba19 View commit details
    Browse the repository at this point in the history

  2. [#12048] Remove feedbackSession attributes @fetch annotation (#12992) 

    * Remove feedbackSession @fetch annotation
    @NicolasCwy
    NicolasCwy authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6c420fa View commit details
    Browse the repository at this point in the history

  3. Remove unused modal (#12998)

    @dishenggg
    dishenggg authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    cfff21d View commit details
    Browse the repository at this point in the history

  4. use transactions for reject account request action (#13001)

    @domoberzin
    domoberzin authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    50c87bc View commit details
    Browse the repository at this point in the history

  5. [#12048] create skeleton for sql LNP tests (#12994) 

    * create skelton for sql LNP tests

* allow lnp test to access sql storage and ensure sql lnp tests are independant of each other

---------

Co-authored-by: Zhang Ziqing <[email protected]>
    @cedricongjh @ziqing26
    cedricongjh and ziqing26 authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8f43cc8 View commit details
    Browse the repository at this point in the history

  6. [#12048] Migrate FeedbackNumScaleQuestionE2ETest (#12940) 

    * Migrate num scale e2e

* Fix team id

* Fix bugs
    @marquestye
    marquestye authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b9ccd4f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. [#11878] Create Rejection Modal for Account Requests (#12989) 

    * Create rejection modal

* fix lint and tests

* fix placeholders and lint

* remove title

* integrate api

* check undefined title and body

* fix trailing white spaces

* fix whitespace

* change error message

* re-add account request table on home page

* replace support email
    @domoberzin
    domoberzin authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a36ecf7 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Add v9.0.0 tag to liquibase changelog (#13005)

    @NicolasCwy
    NicolasCwy authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2354975 View commit details
    Browse the repository at this point in the history

  2. [#11878] Update DeleteAccountRequest to reference by ID (#12997) 

    * Update to delete by id

* fix lint

* fix lint

* fix frontend lint
    @dishenggg
    dishenggg authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6de9607 View commit details
    Browse the repository at this point in the history

  3. [#11878] Update ResetAccountRequest to reference by ID (#13002) 

    * Update reset to reference by id

* fix comments
    @dishenggg
    dishenggg authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e0beb08 View commit details
    Browse the repository at this point in the history

  4. [#11878] Add Error Message for Approving Existing Account (#13004) 

    * add error message for duplicate account request

* add tests
    @domoberzin
    domoberzin authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ce75a0a View commit details
    Browse the repository at this point in the history

  5. sort courses by id before comparison (#13003) 

    Co-authored-by: Dominic Lim <[email protected]>
    @cedricongjh @domlimm
    cedricongjh and domlimm authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    fb7c4e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. [#11878] Get account request by uuid (#13007) 

    * change GetAccountRequestAction to get by id

* fix tests

* remove unncessary todo
    @cedricongjh
    cedricongjh authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    41524a5 View commit details
    Browse the repository at this point in the history

  2. [#11878] Handle Duplicate Approved Account Requests (#13009)

    @domoberzin
    domoberzin authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    451a25a View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. [#11878] Merge master into feature (#13011) 

    * Update chrome driver download link in e2e-testing.md (#12924)

* [#12048] Add SQL configuration into build.properties and build-dev.properties (#12917)

* Add production config

* Remove forgotten host and password

* Fix lint

---------

Co-authored-by: Zhang Ziqing <[email protected]>

* [#12048] Add SQL description for postgres config (#12931)

* Add production config

* Remove forgotten host and password

* Fix lint

* Address changes, include production_user

* Linting

* [#12588] Improve test code coverage of core components - ToastComponent (#12916)

* add test cases

* add test case for isTemplate()

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>

* [#12588] Add unit tests to question edit answer form (#12935)

* add unit tests to constsum-options-question-edit-answer-form

* add unit tests to constsum-options-question-edit-answer-form

---------

Co-authored-by: Zhang Ziqing <[email protected]>

* add delay to task queuer for indexing account request (#12936)

Co-authored-by: Nicolas <[email protected]>

* Make account req data migration script rerunnable (#12932)

* [#12048] Relax read notif verification for migration verification script (#12937)

* Fix account requests with wrong field during seed

* Relax account attributes verification

* Fix lint errors

* Fix order of account request variables

* [#12920] Create script to migrate noSQL test data to SQL schema format (#12922)

* Add classes to migrate test json data

* Add toposort  script

* Add function to remove foreign key data

* Cleanup

* WIP

* Simplify keys for students and instructors

* Fix lint issues

* Output SQL JSON in same folder as JSON

* Change output file name

* Fix bug: wrong jsonkey used

* Fix lint error

* Make section and team name unique

* Set read notification key to be unique

* Delete python file

* [#12588] Improve test code coverage of core components - ViewResultsPanelComponent (#12918)

* add test cases to ViewResultsPanelComponent

* fix lint errors

---------

Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>

* fix resetAccountAction (#12934)

Co-authored-by: Zhang Ziqing <[email protected]>

* [#12048] Migrate Feedback Rank Option E2E test (#12902)

* Initial commit

* Fix lint

* Follow convention and add test

* Change file path

* Fix requested changes

* Fixed testcases

* Fix lint

* Add deepcopy

* Fixed e2e test

---------

Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>

* [#12048] Migrate FeedbackMcqQuestionE2ETest (#12820)

* Migrate MCQ E2E

* Fix lint

* Fix lint

* Update xml

---------

Co-authored-by: Cedric Ong <[email protected]>

* [#12048] Remove unnecessary loading of datastore entities in InstructorNotificationsPageE2ETest (#12911)

* migrate instructor notif e2e

---------

Co-authored-by: Cedric Ong <[email protected]>

* [#12048] Migrate InstructorCourseDetailsPageE2ETest (#12908)

* Add teammates.e2e.cases.sql.InstructorCourseDetailsPageE2ETest

* Remove data properly to prevent clashes

* Add SQL data bundle

* Verify loaded details

* Use email address when getting a student row

* Check student links

* Verify the sending of invites

* Verify the reminding of all students to join

* Remove SQL data properly to prevent clashes

* Verify the downloading of the student list

* Implement helper methods for Student

* Add BaseTestCaseWithSqlDatabaseAccess::verifyAbsentInDatabase

* Add to testng-e2e-sql.xml

* Verify the deleting of students

* Verify the deleting of all the students

* Fix lint

* Remove duplicate equality check for students

* [#12588] add unit tests for question submission form (#12897)

Co-authored-by: Zhang Ziqing <[email protected]>

* Update developers.json (#12958)

* Merge pull request #12960 from TEAMMATES/master (#12961)

* [#12048] Fix account request indexing (#12967)

* Add isTransactionNeeded method to Action

* Remove delay from taskqueuer

* Change CreateAccountRequest to handle own transactions

* configure agroal connection pool (#12971)

* [#12048] Configure connection pool using hikari (#12978)

* Configure hikari

* Remove spacing

* Lint

* [#12048] Update liquibase configuration (#12930)

* Update gradle config

* Update liquibase config for v9

* Turn off table generate for prod

* Update of changelog file

* Add configuration for generating changelog

* Add schema migration docs

---------

Co-authored-by: FergusMok <[email protected]>

* [#12048] Migrate AccountRequestsLogicTest (#12780)

* Migrate test cases for AccountRequestsLogic

* Remove test case

* Split test cases

* [#12048] Migrate AdminSearchPageE2ETest SQL (#12811)

* test e2e changes

* fix: reduce e2e test json file size

* fix student key

* fix course key

* fix instructor keys

* fix filepath

* fix e2e test

* remove extra data from bundle

* Add correct removal logic to avoid constraint violation

* Fix e2e tests and lint

fix reset google id test

fix e2e tests

fix e2e tests

fix tests

remove double click

fix unknown symbol

add toast check

change toast verification message

remove toast check

* fix: add null check

* move admin search page e2e test to sql cases

* Rename AdminSearchPageE2ETest_SQLEntities.json to AdminSearchPageE2ETest_SqlEntities.json

* fix failing test

* fix: remove extra null check

* fix: add test to e2e sql xml file

* fix function call

* remove unnecessary changes

* create new file for sql entities

* revert unnecessary changes

* remove trailing whitespace

* add teardown for account requests

---------

Co-authored-by: Cedric Ong <[email protected]>

* [#12995] Create documentation for unit tests (#12996)

* Create documentation for unit tests

* Update docs/unit-testing.md

Co-authored-by: Zhang Ziqing <[email protected]>

* Update docs/unit-testing.md

Co-authored-by: Zhang Ziqing <[email protected]>

---------

Co-authored-by: Zhang Ziqing <[email protected]>

* [#12048] Remove feedbackSession attributes @fetch annotation (#12992)

* Remove feedbackSession @fetch annotation

* [#12048] create skeleton for sql LNP tests (#12994)

* create skelton for sql LNP tests

* allow lnp test to access sql storage and ensure sql lnp tests are independant of each other

---------

Co-authored-by: Zhang Ziqing <[email protected]>

* [#12048] Migrate FeedbackNumScaleQuestionE2ETest (#12940)

* Migrate num scale e2e

* Fix team id

* Fix bugs

* Add v9.0.0 tag to liquibase changelog (#13005)

* sort courses by id before comparison (#13003)

Co-authored-by: Dominic Lim <[email protected]>

---------

Co-authored-by: Nada Ayesh <[email protected]>
Co-authored-by: FergusMok <[email protected]>
Co-authored-by: Maureen Chang <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Nicolas <[email protected]>
Co-authored-by: Ching Ming Yuan <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: DS <[email protected]>
Co-authored-by: Jay Aljelo Ting <[email protected]>
Co-authored-by: Xenos F <[email protected]>
Co-authored-by: domoberzin <[email protected]>
Co-authored-by: Marques Tye Jia Jun <[email protected]>
    @ziqing26 @nadasuhailAyesh12
    @FergusMok @techMedMau @cedricongjh @domlimm @NicolasCwy @mingyuanc @weiquu @dishenggg @jayasting98 @xenosf @domoberzin @marquestye
    14 people authored Apr 13, 2024
    Configuration menu
    Copy the full SHA
    2bd06e2 View commit details
    Browse the repository at this point in the history

  2. [#11843] Update front end for session activity logs (#12973) 

    * Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs

* Create skeleton

* Implement logic and db layer

* fix lint

* Update entity

* Fix tests

* Update action to use fslDb

* Fix tests

* Update DbIT to use databundle

* Fix bugs and optimize action

* Prevent courseId from being null

* Update GCP logs to store ids

* Fix tests

* Update action to use reference

* Add some error handling

* Fix tests

* Add ids to api output

* Fix lint

* Update front end

* Update cron.yaml

* Update front end

* Fix result display

* Tidy up code

* Update actions to use getUuid

* Fix formatting

* Fix bug

* Add buttons to access page

* Shift logging

* fiox bug

* fix fe tests

* Fix bug

* Fix tests

* Add IT

* remove email and fsname

* fix ts lint

* Fix status message

* Remove front end error messages

* Add assertion fortests

* Fix migrated check

* Change to use id

* Update javadoc

* Change cron job to 15 mins intervals

* fix tests

* fix fe bug

* Add delay note

* Update to use const

* Add const

* fix fe tests
    @dishenggg
    dishenggg authored Apr 13, 2024
    Configuration menu
    Copy the full SHA
    8d506a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. [#11878] Add tests for Account Request Table (#12977) 

    * add component tests for account request table

* modify tests

* remove old tests

* remove comment

* remove unnecessary code

* add tests

* update disabled criteria

* remove extra builders and update snaps
    @domoberzin
    domoberzin authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    4682dff View commit details
    Browse the repository at this point in the history

  2. [#11878] Reference account requests by ID in tests (#13017) 

    * Reference by ID in GetCourseJoinStatusActionIT

* Reference by ID in AccountRequestsDbIT

* Reference by ID in AccountRequestsLogicIT

* Reference by ID in CreateAccountActionIT

* Reference by ID in BaseTestCaseWithSqlDatabaseAccess

* Remove now irrelevant reference by email address and institute
    @jayasting98
    jayasting98 authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    c6b8642 View commit details
    Browse the repository at this point in the history

  3. [#11878] Fix Approval Email Bug (#13027)

    @domoberzin
    domoberzin authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    f0e2af3 View commit details
    Browse the repository at this point in the history

  4. [#11878] Fix reject email content (#13029)

    @ziqing26
    ziqing26 authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    589ba08 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into account-request-form

    @ziqing26
    ziqing26 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    9431906 View commit details
    Browse the repository at this point in the history

  6. [#11878] Add Toasts (#13028) 

    * add toasts

* lint
    @domoberzin
    domoberzin authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    0f0fd05 View commit details
    Browse the repository at this point in the history

  7. [#11878] Remove mention of home page URL from confirmation email (#13030 

    )
    @xenosf
    xenosf authored Apr 14, 2024
    Configuration menu
    Copy the full SHA
    bb261f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Initial commit (#13024)

    @mingyuanc
    mingyuanc authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    98d9044 View commit details
    Browse the repository at this point in the history

  2. fix highlighting and null statuses (#13031)

    @domoberzin
    domoberzin authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    20c29e5 View commit details
    Browse the repository at this point in the history

  3. [#11878] Fix Overlapping Tooltip (#13026) 

    * fix tooltip

* re-add removed lines

* update snap

* update snaps

* lint

* suppress warning

* lint
    @domoberzin
    domoberzin authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3dab1dc View commit details
    Browse the repository at this point in the history

  4. [#11878] Check if account request is not created by admin before send… 

    …ing email (#13032)

* Add check if admin when creating account request

* Trim down test case
    @xenosf
    xenosf authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    665752c View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. [#11878] Add sort by created_at for getAllPendingRequests (#13038) 

    * feat: add order-by

* fix: fix failing test case

* fix: add missing created-at field

* fix: test case comment
    @EuniceSim142
    EuniceSim142 authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7b05fec View commit details
    Browse the repository at this point in the history

  2. [#11878] Request Page E2E (#13015) 

    * Add E2E skeleton

* Fix test and lint

* Add verifyEmailSent

* fix fe tests
    @dishenggg
    dishenggg authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    16f7767 View commit details
    Browse the repository at this point in the history

  3. [#12954] CreateAccountAction seems to have redundant code (#13039) 

    * Removed redundant code

* Removed reduntant code

* Removed trailing whitespaces

* Removed trailing whitespaces
    @eraldprifti03
    eraldprifti03 authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    735afbd View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. [#12048] Fix getSessionResultAction bugs (#13023) 

    * [#12048] Config prod settings and convenience scripts  for non course migration (#12959)

* Add fields

* Change based on feedback

* Add changes

* Add reverse data migration script for account (#12962)

* Add changes (#12965)

* V9 non course migration fix to check extra SQL accounts (#12966)

* Add changes

* Add isMarked script

* Add patch data migration script for usage stats (#12970)

* Add patch data migration script for usage stats

* Fix hibernate batch query

* Revert log

* Initial commit

* Revert "[#12048] Config prod settings and convenience scripts  for non course migration (#12959)"

This reverts commit 6df39c1.

* Revert "Add reverse data migration script for account (#12962)"

This reverts commit 0509982.

* Revert "V9 non course migration fix to check extra SQL accounts (#12966)"

This reverts commit 611b2cc.

* Revert "Add patch data migration script for usage stats (#12970)"

This reverts commit 239ae85.

* Revert "Add changes (#12965)"

This reverts commit 1292dbe.

* Fix lint

* Retry lint

---------

Co-authored-by: FergusMok <[email protected]>
Co-authored-by: Zhang Ziqing <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
    @mingyuanc @FergusMok
    @ziqing26 @weiquu
    4 people authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f852286 View commit details
    Browse the repository at this point in the history

  2. Remove method from logic and db (#13044)

    @dishenggg
    dishenggg authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3915b8c View commit details
    Browse the repository at this point in the history

  3. [#11878] Migrate AccountRequestsLogic unit tests (#13043) 

    * Add get typical account request method

* Migrate AccountRequestsLogicTest

* Remove test for get by email address and institute

---------

Co-authored-by: Jay Aljelo Ting <[email protected]>
    @xenosf @jayasting98
    xenosf and jayasting98 authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ab22022 View commit details
    Browse the repository at this point in the history

  4. [#11878] Add Admin E2E Tests (#13020) 

    * add admin e2e tests

* remove exception catching and update snaps

* fix snaps

* add comment verification

* fix test
    @domoberzin
    domoberzin authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    68a4fbf View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into account-request-form

    @ziqing26
    ziqing26 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    78e49b7 View commit details
    Browse the repository at this point in the history

  6. [#11878] Add SQLI tests (#13047)

    @xenosf
    xenosf authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2cc6ef8 View commit details
    Browse the repository at this point in the history

  7. Revert "Enable CI on account request form branch" (#13049) 

    This reverts commit 186a97a.
    @ziqing26
    ziqing26 authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5378b66 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. [#11843] Fix front end bugs (#13037) 

    * Fix notViewedSince

* Update disclaimer

* Change disclaimer message

* Fix view result message

* Fix not viewed since message
    @dishenggg
    dishenggg authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9a51e2a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into student-activity-logs

    @FergusMok
    FergusMok authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    000e8b7 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #13051 from TEAMMATES/account-request-form 

    [#11878] Account request form
    @ziqing26
    ziqing26 authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c76df68 View commit details
    Browse the repository at this point in the history

  4. Fixed moderate response bug (#12964) 

    Added a propagation stop to the moderate response button

Co-authored-by: Wei Qing <[email protected]>
    @eraysozer20 @weiquu
    eraysozer20 and weiquu authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6fe8c8d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into student-activity-logs

    @cedricongjh
    cedricongjh authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3e25beb View commit details
    Browse the repository at this point in the history

  6. [#12048] Migrate committers (#13052) 

    * Add committers

* Remove contributors
    @ziqing26
    ziqing26 authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8ec6989 View commit details
    Browse the repository at this point in the history

  7. fix lint issues

    @cedricongjh
    cedricongjh committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d241a78 View commit details
    Browse the repository at this point in the history

  8. [#12048] Migrate InstructorStudentRecordsPageE2ETest (#13013) 

    * migrate InstructorStudentRecordsPageE2ETest

* Add InstructorStudentRecordsPageE2ETest to sql xml

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    63b3209 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #13041 from TEAMMATES/student-activity-logs 

    [#11843] Merge student-activity-logs into master
    @cedricongjh
    cedricongjh authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    14344cf View commit details
    Browse the repository at this point in the history

  10. [#12725] Update backend libraries versions, support Java 21 (#12885) 

    * Update gradle version

* Update libraries

* Update code

* Update actions versions

* Add workflow for JDK 21
    @wkurniawan07
    wkurniawan07 authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    acc16f2 View commit details
    Browse the repository at this point in the history

  11. fix edit (#13056) 

    Co-authored-by: Zhang Ziqing <[email protected]>
    @domoberzin @ziqing26
    domoberzin and ziqing26 authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ce839ab View commit details
    Browse the repository at this point in the history

  12. [#12048] Migrate InstructorStudentListPageE2ETest (#13014) 

    * Migrate InstructorStudentListPageE2ETest

* Add InstructorStudentListPageE2ETest to sql xml

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4aa2af7 View commit details
    Browse the repository at this point in the history

  13. [#12048] Migrate instructor home page e2e test (#13016) 

    * return FeedbackSession directly from moveFeedbackSessionToRecycleBin

* Add verify accessible for RestoreFeedbackSessionAction and pass correct params to fsDb.getSoftDeletedFeedbackSession

* add feedbacksession to getEntity

* add getfeedbacksession methods

* migrate instructorhome page e2e test

* fix checkstyle issues

* fix pmd issues

* sort course by name instead of creation time

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c665348 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. migrate StudentCourseJoinConfirmationPageE2ETest (#13008) 

    Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1027334 View commit details
    Browse the repository at this point in the history

  2. [#11878] Fix console errors (#13058)

    @domoberzin
    domoberzin authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f8bae93 View commit details
    Browse the repository at this point in the history

  3. [#11878] Fix Rejection Modal (#13059)

    @domoberzin
    domoberzin authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ba6979e View commit details
    Browse the repository at this point in the history

  4. Add composite index for data migration (#13057) 

    Co-authored-by: FergusMok <[email protected]>
    @marquestye @FergusMok
    marquestye and FergusMok authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    498efdc View commit details
    Browse the repository at this point in the history

  5. [#13060] Add beta 5 liquibase changelog and developers json (#13061) 

    * Add beta 5 changelog

* Update changelog to be in alphabetical order

* Update developers.json
    @ziqing26
    ziqing26 authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    81eae17 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. [#12048] Update changelog docs and changelog name (#13062) 

    * Update docs

* Rename changelog file

* Amend changelog naming
    @NicolasCwy
    NicolasCwy authored Apr 20, 2024
    Configuration menu
    Copy the full SHA
    0a0e7c9 View commit details
    Browse the repository at this point in the history

  2. [#12048] Migrate StudentCourseDetailsPageE2ETest (#13012) 

    * Migrate StudentCourseDetailsPageE2ETest

* Add StudentCourseDetailsPageE2ETest to sql xml

---------

Co-authored-by: Wei Qing <[email protected]>
    @cedricongjh @weiquu
    cedricongjh and weiquu authored Apr 20, 2024
    Configuration menu
    Copy the full SHA
    10e96cb View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. [#11878] Account Request Indexing Script (#13076) 

    * add script

* order commit

* update logic

* convert to batch

* remove print
    @domoberzin
    domoberzin authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    76db4cc View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. [#11878] Add CAPTCHA to ARF (#13081) 

    * Add captcha to ARF

* Update front-end tests

* Fix lint errors

* Change captcha to uppercase in error text

* Return captcha response when the getter is called

---------

Co-authored-by: Jay Aljelo Ting <[email protected]>
    @xenosf @jayasting98
    xenosf and jayasting98 authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6b83e4f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. [#13064] Use AccountRequestUpdateRequest as parameter (#13068) 

    * Update editAccountRequest parameter type to AccountRequestUpdateRequest

* Fixing the lint

* Refatoring editAccountRequest method

---------

Co-authored-by: Cedric Ong <[email protected]>
    @Stain19 @cedricongjh
    Stain19 and cedricongjh authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e738e25 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. [#12048] Migrate FeedbackRubricQuestionsE2E (#13078) 

    * Add e2e test

* Migrate all tests

* Update xml

---------

Co-authored-by: YX Z <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
    @yuanxi1 @weiquu
    3 people authored Apr 28, 2024
    Configuration menu
    Copy the full SHA
    a2a9ef3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. [#12048] Migrate SubmitFeedbackResponseAction tests (#13033) 

    * Skeleton till shouldAllowIfBeforeDeadline

* Save progress

* Save progress

* Fix all tests

* Fix linting

* Remove redundant

* Refactor to fit integration tests structure

* Add breaking changes

* Add flush

* Fix linting

* Fix clean-up from access control
    @FergusMok
    FergusMok authored May 2, 2024
    Configuration menu
    Copy the full SHA
    34248a0 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. [#12900] Gradle task componentTests should not stop entirely when onl… 

    …y one task fails (#12963)
    @emrekenar
    emrekenar authored May 12, 2024
    Configuration menu
    Copy the full SHA
    1ea04f4 View commit details
    Browse the repository at this point in the history

  2. [#12048] Remove null default section (#13040) 

    * Add changes

* Add missing

---------

Co-authored-by: Nicolas <[email protected]>
Co-authored-by: Wilson Kurniawan <[email protected]>
    @FergusMok @NicolasCwy @wkurniawan07
    3 people authored May 12, 2024
    Configuration menu
    Copy the full SHA
    06bfafd View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. [#13126] Fix failing component test cases (#13127) 

    * Fix failing test cases

* Update test logs with unique sorting order

* Revert AccountRequestDbIT
    @dishenggg
    dishenggg authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7b75dad View commit details
    Browse the repository at this point in the history

  2. [#13126] Update timezone db (#13128)

    @wkurniawan07
    wkurniawan07 authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5ed1cf7 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. [#13109] IndexOutOfBoundsException encountered by LogsProcessor (#13120) 

    * #13109-added check to see if logs is empty

* switch back to logs.get(list.size()-1)

* [#13109] IndexOutOfBoundsException encountered by LogsProcessor

---------

Co-authored-by: domoberzin <[email protected]>
    @Ashwinn11 @domoberzin
    Ashwinn11 and domoberzin authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ec1f276 View commit details
    Browse the repository at this point in the history

  2. [#13103] Account request form: No need to CC the email 'Acknowledgeme… 

    …nt of Instructor Account Request' (#13116)
    @Ashwinn11
    Ashwinn11 authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6114677 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Remove duplicate call to loadfeedbacksessionsforcourse (#13130)

    @Respirayson
    Respirayson authored Jun 22, 2024
    Configuration menu
    Copy the full SHA
    40350ef View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. [#13102] Admin rejecting account request: give actual account in the … 

    …email template (#13118)

* Change existingEmail to googleId

* Add extra info to instructions

* Fix missing googleId if multiple accounts exist

* Add function name to test name

* Move account search to function

* Change missing googleId string to be shorter

* Add check for accounts with no googleId

* Add tests for replaceGoogleId

* Change instructor search result to use createBuilder

* Change a test name to fit convention

---------

Co-authored-by: domoberzin <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
    @Andy-W-Developer @domoberzin @weiquu
    3 people authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    efeffd4 View commit details
    Browse the repository at this point in the history

  2. [#12901] Check if the search service is active in account request sea… 

    …rch test (#13101)

* added check for active search service in account request search test

* moved account request search test to AccountRequestSearchIT and updated variables and asserts accordingly

* Add caution note to instructor email copies and remove hyperlinks

* updated account request test constructor to be consistent with latest commits

* fixed style errors

* fixed compiler errors

* fixed assertion error and style

* fixed linter errors

* Revert "Add caution note to instructor email copies and remove hyperlinks"

This reverts commit 232c757.

---------

Co-authored-by: Carolyn Liu <[email protected]>
Co-authored-by: Anna Zhang <[email protected]>
Co-authored-by: DS <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
    @cliu585 @azhang49
    @dishenggg @weiquu
    5 people authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    015b872 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. [#13105] Admin managing account requests: use spinners to indicate ac… 

    …tions in progress (#13135)

* Add spinners for approve, reject and reset in account-request-table

* Add spinners to regenerate keys in admin-search-page

* Update spinners in account-request-table to work individually

* Update tests

* Update buttons to be disabled while loading
    @Respirayson
    Respirayson authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b402863 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. [#12872] Warn instructors not to share link with students (#13137) 

    * Add caution to template and change tests

* Update tests

* Fix failing test

* Change phrasing

* Fix typo

* Modify email template and tests

* Fix typo
    @itstrueitstrueitsrealitsreal
    itstrueitstrueitsrealitsreal authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f604c11 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. [#12578] @ sign is shown as &#64; when viewing essay question sub… 

    …mission page (#13142)

* Add decoding html entity functionality

* Add unit tests

---------

Co-authored-by: domoberzin <[email protected]>
    @Respirayson @domoberzin
    Respirayson and domoberzin authored Jul 7, 2024
    Configuration menu
    Copy the full SHA
    836f637 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. [#12779] Fix notifications update logic (#13083) 

    * Fix notifications update logic

* Add required mocks

---------

Co-authored-by: Ching Ming Yuan <[email protected]>
    @marquestye @mingyuanc
    marquestye and mingyuanc authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    399a5fa View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. [#12894] Calculate msq totals by student email instead of name (#13141) 

    * Calculate totals by email

* Standardize mcq and msq

* Undo sortBy

* Refactor initialization of variables

---------

Co-authored-by: domoberzin <[email protected]>
    @itstrueitstrueitsrealitsreal @domoberzin
    itstrueitstrueitsrealitsreal and domoberzin authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c5af284 View commit details
    Browse the repository at this point in the history

  2. [#12048] Migrate InstructorCourseStudentDetailsEditPageE2ETest (#13069) 

    * migrate

* get name from section and team

* update team

* fix data issues

---------

Co-authored-by: Ching Ming Yuan <[email protected]>
Co-authored-by: domoberzin <[email protected]>
    @weiquu @mingyuanc @domoberzin
    3 people authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    13a1891 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. [#13104] Accounts request form: auto-unify country names (#13117) 

    * Added unified countries for InstructorRequestForm

* Added tests for InstructorRequestForm for unified countries

* Fixed lint errors for InstructorRequestForm

* Added countries and moved countrymapping

* Tests Fixed

---------

Co-authored-by: Francisco Savala <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Ching Ming Yuan <[email protected]>
Co-authored-by: domoberzin <[email protected]>
    @franciscoSavala @franciscoSavalaML
    @weiquu @mingyuanc @domoberzin
    5 people authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3f5f68d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. [#12655] Instructor Edit Session Page: If make session visible is lat… 

    …er than submission opening time, automatically default to opening time (#13143)

* Update functionality to ensure session visibility time defaults to submission opening time

* Add unit tests

* Fix linting
    @Respirayson
    Respirayson authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    61df45a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. [#12749] Autosave and restore progress if user navigates away (#13140)

    @Respirayson
    Respirayson authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    67628fb View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. [#12588] Test coverage improvements for InstructorResponsesViewBase (#… 

    …13087)

* test coverage improvements for InstructorResponsesViewBase

* Lint fixes

* Update per-question-view-responses.component.spec.ts

* Fix for component tests

---------

Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: domoberzin <[email protected]>
    @justinsegawa @weiquu @domoberzin
    3 people authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6b7912c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. [#13147] Didn't Account for the Timezone in Session Edit Form compone… 

    …nt tests (#13148)
    @Respirayson
    Respirayson authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    9181467 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. [#11383] Add detection of PRs linking to closed issues (#13154) 

    * Add check for closed issue

* Update message

* Rephrase message

* Add logging

* Test

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Add check for closed issue

Update message

Rephrase message

Add logging

Test

Update pr.yml

* [#13147] Didn't Account for the Timezone in Session Edit Form component tests (#13148)

Update pr.yml

Update pr.yml

Update pr.yml

* Update pr.yml

* Update workflow

---------

Co-authored-by: Rayson Yeap <[email protected]>
    @itstrueitstrueitsrealitsreal @Respirayson
    itstrueitstrueitsrealitsreal and Respirayson authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ea30a05 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. [#12169] Update teammates-eslint.yml to mark trailing whitespaces a… 

    …s errors on Ubuntu (#13152)

* Modify eslint ruleset

* Fix checkstyle

* Fix checkstyle

* Edit ruleset

* Fix checkstyle

* Fix checkstyle

* Fix checkstyle

---------

Co-authored-by: Ching Ming Yuan <[email protected]>
    @itstrueitstrueitsrealitsreal @mingyuanc
    itstrueitstrueitsrealitsreal and mingyuanc authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    cdee5f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. [#12664] - Instructor's Student Records Page: Accessibility issue for… 

    … comment buttons (#13155)
    @NeoHW
    NeoHW authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    499bde8 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Change docker compose command (#13159)

    @domoberzin
    domoberzin authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    2393888 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Create cancel button for instructor request form (#13156) 

    Co-authored-by: domoberzin <[email protected]>
    @NeoHW @domoberzin
    NeoHW and domoberzin authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3fddf47 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. [#12375] Update phrasing of contact page (#13157) 

    * Update phrasing of contact page

* Update phrasing and add icon

* Add additional icons

---------

Co-authored-by: domoberzin <[email protected]>
    @itstrueitstrueitsrealitsreal @domoberzin
    itstrueitstrueitsrealitsreal and domoberzin authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6d4f9f4 View commit details
    Browse the repository at this point in the history