[#12596] Part of issue the table doesn't sort by team #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix lint * Migrate instructor search indexing worker action * Fix Checkstyle * Fix Checkstyle * Fix Checkstyle * Add testcases * Update comparator to Id --------- Co-authored-by: Cedric Ong <[email protected]> Co-authored-by: Nicolas <[email protected]>
* feat: add tests for CoursesLogic * fix: verify parameters of mocked logic classes * fix: lint issues * fix: add additional verification of parameters --------- Co-authored-by: Cedric Ong <[email protected]>
…12732) * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade --------- Co-authored-by: Nicolas <[email protected]>
* Add CRUD testcases * Fix linting * Refactor getTypicalComment * Amend testDeleteComment testcase * Amend testDeleteComment testcase * Fix compile error * Revert linting changes --------- Co-authored-by: Nicolas <[email protected]>
* Initial draft for migrated Remove unnecessary comments Remove unnecessary comments Save progress Add draft Add draft * Add tests * Add implementation * Add implementation * Add implementation * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade * Revert unnecessary changes, add tests * Fix linting and tests * Merge changes with db * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade * Revert unnecessary changes, add tests * Fix linting and tests * Save progress * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade Revert unnecessary changes, add tests Fix linting and tests Add changes Revert changes Revert changes Add tests Add lint changes * Fix linting errors * Clean up commits * Disable failing test * Replace giver with updatedAt to make test clearer * Add IT setUp * Save progress on tests * Revert test-related changes * Revert test-related changes, clean linting * Correct spelling mistakes --------- Co-authored-by: Cedric Ong <[email protected]>
* Create Put and Delete Sql Databundle actions * deduplicate courses in GetCoursesAction * add remove and restore sql databundle method to BACKDOOR * Migrate StudentHomePageE2ETest * fix architecture tests * fix tests * Empty-Commit * skip sql data bundle checking * create new class * fix pmd violation * Empty-Commit2 * Empty-Commit3
* Add test for FeedbackSessionsDb * update test cases --------- Co-authored-by: Cedric Ong <[email protected]>
[#12048] Merge in current v9-migration
* Persist ReadNotifications in databundle * Add remove or replace sql databundle methods into base test case * Remove unnecessary checking of account migrated * Migrate StudentNotificationPageE2ETest * Fix lint issues * Return sqldatabundle for tests * Revert changes to NotificationPage to use notification id instead * Add assertion for readNotifications from account * fix architectureTest --------- Co-authored-by: Wei Qing <[email protected]>
* fix GetFeedbackQuestionsAction bug * migrate over getEntity and verifyEquals * migrate FeedbackTextQuestionE2ETesty * fix lint * fix lint --------- Co-authored-by: Wei Qing <[email protected]>
* make courses to be created in datastore * mirgate InstructorCoursePageE2ETest * fix lint --------- Co-authored-by: Wei Qing <[email protected]>
* Migrate GetSessionResponseStatsAction * fix: fix NPE issues * fix: remove extra comments * fix: remove extra line --------- Co-authored-by: Zhang Ziqing <[email protected]> Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Zhang Ziqing <[email protected]>
Co-authored-by: Cedric Ong <[email protected]>
* migrate AdminHomePageE2ETest * fix lint --------- Co-authored-by: EuniceSim142 <[email protected]>
) * Migrate GetSessionResponseStatsAction * fix: fix NPE issues * feat: add IT for GetFeedbackSessionSubmittedGiverSetAction * fix: remove extra comment * fix: remove duplicate method --------- Co-authored-by: Zhang Ziqing <[email protected]> Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Zhang Ziqing <[email protected]>
* Add captcha to ARF * Update front-end tests * Fix lint errors * Change captcha to uppercase in error text * Return captcha response when the getter is called --------- Co-authored-by: Jay Aljelo Ting <[email protected]>
* Update editAccountRequest parameter type to AccountRequestUpdateRequest * Fixing the lint * Refatoring editAccountRequest method --------- Co-authored-by: Cedric Ong <[email protected]>
* Add e2e test * Migrate all tests * Update xml --------- Co-authored-by: YX Z <[email protected]> Co-authored-by: Wei Qing <[email protected]>
* Skeleton till shouldAllowIfBeforeDeadline * Save progress * Save progress * Fix all tests * Fix linting * Remove redundant * Refactor to fit integration tests structure * Add breaking changes * Add flush * Fix linting * Fix clean-up from access control
…y one task fails (#12963)
* Add changes * Add missing --------- Co-authored-by: Nicolas <[email protected]> Co-authored-by: Wilson Kurniawan <[email protected]>
* #13109-added check to see if logs is empty * switch back to logs.get(list.size()-1) * [#13109] IndexOutOfBoundsException encountered by LogsProcessor --------- Co-authored-by: domoberzin <[email protected]>
…nt of Instructor Account Request' (#13116)
…email template (#13118) * Change existingEmail to googleId * Add extra info to instructions * Fix missing googleId if multiple accounts exist * Add function name to test name * Move account search to function * Change missing googleId string to be shorter * Add check for accounts with no googleId * Add tests for replaceGoogleId * Change instructor search result to use createBuilder * Change a test name to fit convention --------- Co-authored-by: domoberzin <[email protected]> Co-authored-by: Wei Qing <[email protected]>
…rch test (#13101) * added check for active search service in account request search test * moved account request search test to AccountRequestSearchIT and updated variables and asserts accordingly * Add caution note to instructor email copies and remove hyperlinks * updated account request test constructor to be consistent with latest commits * fixed style errors * fixed compiler errors * fixed assertion error and style * fixed linter errors * Revert "Add caution note to instructor email copies and remove hyperlinks" This reverts commit 232c757. --------- Co-authored-by: Carolyn Liu <[email protected]> Co-authored-by: Anna Zhang <[email protected]> Co-authored-by: DS <[email protected]> Co-authored-by: Wei Qing <[email protected]>
…tions in progress (#13135) * Add spinners for approve, reject and reset in account-request-table * Add spinners to regenerate keys in admin-search-page * Update spinners in account-request-table to work individually * Update tests * Update buttons to be disabled while loading
…mission page (#13142) * Add decoding html entity functionality * Add unit tests --------- Co-authored-by: domoberzin <[email protected]>
* Fix notifications update logic * Add required mocks --------- Co-authored-by: Ching Ming Yuan <[email protected]>
* Calculate totals by email * Standardize mcq and msq * Undo sortBy * Refactor initialization of variables --------- Co-authored-by: domoberzin <[email protected]>
* migrate * get name from section and team * update team * fix data issues --------- Co-authored-by: Ching Ming Yuan <[email protected]> Co-authored-by: domoberzin <[email protected]>
* Added unified countries for InstructorRequestForm * Added tests for InstructorRequestForm for unified countries * Fixed lint errors for InstructorRequestForm * Added countries and moved countrymapping * Tests Fixed --------- Co-authored-by: Francisco Savala <[email protected]> Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Ching Ming Yuan <[email protected]> Co-authored-by: domoberzin <[email protected]>
…er than submission opening time, automatically default to opening time (#13143) * Update functionality to ensure session visibility time defaults to submission opening time * Add unit tests * Fix linting
…13087) * test coverage improvements for InstructorResponsesViewBase * Lint fixes * Update per-question-view-responses.component.spec.ts * Fix for component tests --------- Co-authored-by: Wei Qing <[email protected]> Co-authored-by: domoberzin <[email protected]>
* Add check for closed issue * Update message * Rephrase message * Add logging * Test * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Add check for closed issue Update message Rephrase message Add logging Test Update pr.yml * [#13147] Didn't Account for the Timezone in Session Edit Form component tests (#13148) Update pr.yml Update pr.yml Update pr.yml * Update pr.yml * Update workflow --------- Co-authored-by: Rayson Yeap <[email protected]>
…s errors on Ubuntu (#13152) * Modify eslint ruleset * Fix checkstyle * Fix checkstyle * Edit ruleset * Fix checkstyle * Fix checkstyle * Fix checkstyle --------- Co-authored-by: Ching Ming Yuan <[email protected]>
… comment buttons (#13155)
Co-authored-by: domoberzin <[email protected]>
* Update phrasing of contact page * Update phrasing and add icon * Add additional icons --------- Co-authored-by: domoberzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of TEAMMATES#12596
Outline of Solution
Update the comparison method to handle the "Team" prefix,
Sort based on the numeric value after the prefix.