Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WSG50 with deformable bubble gripper #61

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

xuchenhan-tri
Copy link
Contributor

@xuchenhan-tri xuchenhan-tri commented Apr 4, 2024

Twin Drake PR: RobotLocomotion/drake#21240


This change is Reviewable

Copy link
Contributor Author

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for reviews please? I figured you might have opinions on how I split the models files across models/ and drake/

Sherm already reviewed the content of the sdf file.

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Contributor

For the files being added here, the file arrangement / choice of directories looks good to me. I don't have time to review further -- and generally same feature reviewer should do both twin PRs anyway.

In terms of which files go where between drake vs drake_models, the invariant we want is that meshes live in this repository, and any sdformat / urdf / mjcf files that cite those meshes live here as well (so that e.g. renaming a mesh file is not a cross-repo twin PR change).

Copy link
Contributor Author

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of which files go where between drake vs drake_models, the invariant we want is that meshes live in this repository, and any sdformat / urdf / mjcf files that cite those meshes live here as well

That makes sense and is mostly respected by my PRs. The only sticking point is that I left the teddy bear mesh in the drake repo. The size of the dir remains under 100kB though.

+@sherm1 for review.

Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, LGTM missing from assignee sherm1, platform LGTM missing (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri removed their assignment Apr 4, 2024
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-@jwnimmer-tri
:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [sherm1] (waiting on @jwnimmer-tri)

@xuchenhan-tri xuchenhan-tri merged commit 69c9259 into RobotLocomotion:master Apr 5, 2024
2 checks passed
@xuchenhan-tri xuchenhan-tri deleted the bubbles branch April 5, 2024 00:20
xuchenhan-tri added a commit to xuchenhan-tri/models that referenced this pull request Apr 5, 2024
This reverts commit 69c9259.
Drake isn't ready for a new sdf file with drake:mimic tag yet.
@jwnimmer-tri
Copy link
Contributor

In #62, I'm asking Sean to fix the filenames here. When there are lots of models in the same assets subdir, names like dots.png and dot_pattern.mtl are too difficult to pair with their parent. They should have been textured_bubble.mtl and textured_bubble.png.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants