-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WSG50 with deformable bubble gripper #61
Conversation
214a2f9
to
fb74187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jwnimmer-tri for reviews please? I figured you might have opinions on how I split the models files across models/ and drake/
Sherm already reviewed the content of the sdf file.
Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing (waiting on @jwnimmer-tri)
For the files being added here, the file arrangement / choice of directories looks good to me. I don't have time to review further -- and generally same feature reviewer should do both twin PRs anyway. In terms of which files go where between drake vs drake_models, the invariant we want is that meshes live in this repository, and any sdformat / urdf / mjcf files that cite those meshes live here as well (so that e.g. renaming a mesh file is not a cross-repo twin PR change). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of which files go where between drake vs drake_models, the invariant we want is that meshes live in this repository, and any sdformat / urdf / mjcf files that cite those meshes live here as well
That makes sense and is mostly respected by my PRs. The only sticking point is that I left the teddy bear mesh in the drake repo. The size of the dir remains under 100kB though.
+@sherm1 for review.
Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, LGTM missing from assignee sherm1, platform LGTM missing (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all discussions resolved, platform LGTM from [sherm1] (waiting on @jwnimmer-tri)
This reverts commit 69c9259. Drake isn't ready for a new sdf file with drake:mimic tag yet.
In #62, I'm asking Sean to fix the filenames here. When there are lots of models in the same assets subdir, names like |
Twin Drake PR: RobotLocomotion/drake#21240
This change is