-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QuestionComponent
#1404
Add QuestionComponent
#1404
Conversation
Non-direct questions can't have a non-null answer count
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
==========================================
+ Coverage 95.23% 95.27% +0.03%
==========================================
Files 169 171 +2
Lines 2646 2664 +18
==========================================
+ Hits 2520 2538 +18
Misses 126 126
☔ View full report in Codecov by Sentry. |
Co-authored-by: Georg Gadinger <[email protected]>
@@ -0,0 +1,8 @@ | |||
en: | |||
answers: | |||
zero: "0 answers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could put something like "No answers" or "Unanswered" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zarro answoors found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This technically doesn't appear anyway (answer count must be positive to show uppp), it's just added to match all numerical translation values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then i would suggest to change it to something more fun
zero: "0 answers" | |
zero: "zefix, do is jo nix" |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Requires #1403 to be merged first.
De-duplicates question displays across the application.
Note: Does not include any tests because...
ApplicationComponent
is just a base component exposing Devise user helpers to the componentsI'll try to find a solution for the testing problem later.