Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The layout of the "Show all questions from this user" page is broken #1436

Closed
pixeldesu opened this issue Oct 30, 2023 · 0 comments · Fixed by #1499
Closed

The layout of the "Show all questions from this user" page is broken #1436

pixeldesu opened this issue Oct 30, 2023 · 0 comments · Fixed by #1499
Labels
bug Issues containing bug reports good first issue First tasks that can be approached without much knowledge of the project

Comments

@pixeldesu
Copy link
Member

Steps to reproduce the problem

  1. Look at an anonymous question
  2. Open the "Show all questions from this user" page through the actions

Expected behaviour

The layout of the page looks normal.

Actual behaviour

The header bar containing the anonymous identifier is rendered twice.

Screenshot 2023-10-30 at 10 14 38

Detailed description

This happened in #1404 with the adjustment of the Question page layout, the removal of the .question--fixed class is causing this.

To fix this, adjust the layout of https://github.com/Retrospring/retrospring/blob/main/app/views/moderation/questions/show.html.haml to follow the one in https://github.com/Retrospring/retrospring/blob/main/app/views/question/show.html.haml

Specifications

Retrospring 2023.1028.1

@pixeldesu pixeldesu added bug Issues containing bug reports good first issue First tasks that can be approached without much knowledge of the project labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues containing bug reports good first issue First tasks that can be approached without much knowledge of the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant