Add minor fixes to the C++ code. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iddm
commented
Aug 30, 2023
iddm
commented
- Changes the C++ comments so that those are properly recognised by bindgen and it generates Rust doc-comments for those in the bindings.
- Fixes a few typos.
- Makes sure the correct data slot is used for by introducing special macros.
- Corrects indentation.
Closed
v8_c_api/src/v8_c_api.h
Outdated
|
|
||
| /* Opaque struct representing a v8 interpreter. | ||
| /** An opaque struct representing a v8 platform. */ | ||
| typedef struct v8_platform v8_platform; |
There was a problem hiding this comment.
Follow slack discussion, lets remove it.
v8_c_api/src/v8_c_api.cpp
Outdated
|
|
||
| return 1; | ||
| } | ||
|
|
||
| v8_platform* v8_NewPlatform(const int thread_pool_size) { |
There was a problem hiding this comment.
Follow slack discussion, lets remove it.
iddm
force-pushed
the
add-inspector-api
branch
2 times, most recently
from
74fa5c5
to
2048e4c
Compare
1. Changes the C++ comments so that those are properly recognised by bindgen and it generates Rust doc-comments for those in the bindings. 2. Fixes a few typos. 3. Makes sure the correct data slot is used for by introducing special macros. 4. Corrects indentation.
iddm
force-pushed
the
add-inspector-api
branch
from
2048e4c
to
eda8342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.