Skip to content

Commit

Permalink
Add minor fixes to the C++ code.
Browse files Browse the repository at this point in the history
1. Changes the C++ comments so that those are properly recognised by
   bindgen and it generates Rust doc-comments for those in the bindings.
2. Fixes a few typos.
3. Makes sure the correct data slot is used for by introducing special
   macros.
4. Corrects indentation.
  • Loading branch information
iddm committed Aug 30, 2023
1 parent 7880c18 commit 74fa5c5
Show file tree
Hide file tree
Showing 3 changed files with 972 additions and 955 deletions.
2 changes: 1 addition & 1 deletion src/v8/isolate_scope.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ pub struct V8IsolateScope<'isolate> {
}

extern "C" fn free_external_data<T: 'static>(arg1: *mut ::std::os::raw::c_void) {
unsafe { Box::from_raw(arg1 as *mut T) };
let _ = unsafe { Box::from_raw(arg1 as *mut T) };
}

#[derive(Debug, Clone, Copy)]
Expand Down
Loading

0 comments on commit 74fa5c5

Please sign in to comment.