Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug related to svg in cardreadmore #781

Open
wants to merge 4 commits into
base: v2
Choose a base branch
from
Open

fix: bug related to svg in cardreadmore #781

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cd5f10
fix: bug related to svg in cardreadmore
mamico Oct 1, 2024
e803693
Merge branch 'v2' into cardreadmore_svg_bug
mamico Oct 2, 2024
a3d1e5a
Merge branch 'v2' into cardreadmore_svg_bug
mamico Oct 8, 2024
2e0ff07
Merge branch 'v2' into cardreadmore_svg_bug
mamico Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/ItaliaTheme/Blocks/Listing/CardWithSlideUpTextTemplate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,14 @@ const CardWithSlideUpTextTemplate = (props) => {
<p>{item.description}</p>
)}
<div className="read-more">
{/*
because of https://developer.chrome.com/blog/migrate-way-from-data-urls-in-svg-use
current implementation of Icon in CardReadMore component is not working.
we disable it for now.
iconName="it-arrow-right"
*/}
<CardReadMore
iconName="it-arrow-right"
iconName={false}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
iconName={false}

il default per iconName è 'it-arrow-right'
lo toglierei semplicemente.
se mettiamo {false} non viene disegnata l'icona (che ora si vedeva)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la richiesta di modifica è proprio perchè l'icona non si vede e da molti errori in console, almeno qui:
https://www.auslromagna.it/
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok. occhio che il CardReadMore è usato in tanti posti..
lo fisserei ovunque è usato a questo punto..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giuliaghisini io intanto chiuderei questa.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamico ok. Vedi il mio ultimo commento. C'è da fare un giro e vedere dove è stato usato nel modo sbagliato e correggere come hai fatto

tag={UniversalLink}
item={!isEditMode ? item : null}
href={isEditMode ? '#' : null}
Expand Down
308 changes: 0 additions & 308 deletions src/customizations/volto/components/theme/View/disabled_View.jsx
View file
Open in desktop

This file was deleted.

Loading
Loading