-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug related to svg in cardreadmore #781
base: v2
Are you sure you want to change the base?
Conversation
<CardReadMore | ||
iconName="it-arrow-right" | ||
iconName={false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iconName={false} | |
il default per iconName è 'it-arrow-right'
lo toglierei semplicemente.
se mettiamo {false} non viene disegnata l'icona (che ora si vedeva)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
la richiesta di modifica è proprio perchè l'icona non si vede e da molti errori in console, almeno qui:
https://www.auslromagna.it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok. occhio che il CardReadMore è usato in tanti posti..
lo fisserei ovunque è usato a questo punto..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giuliaghisini io intanto chiuderei questa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamico ok. Vedi il mio ultimo commento. C'è da fare un giro e vedere dove è stato usato nel modo sbagliato e correggere come hai fatto
because of https://developer.chrome.com/blog/migrate-way-from-data-urls-in-svg-use the svg icon in CardReadMore from
design react kit
doesn't work.