Remove 'asDiagram' infrastructure

[niklas-wortmann]

This cleans up the old way of generating marble diagrams. It also hides the internal testing document from the docs, we can still refer to that but it's not visible from the menu anymore.

That's how the new diagrams (inlined as svg) do kinda look like:

[cartant]

LGTM

[timdp]

Guessing this relates to #5019, #5100, and #5402, so just cross-linking for visibility...

[timdp]

Note that Swirly currently introduces a pseudo-circular dependency. In order to parse the ASCII marble diagrams, it depends on the stable rxjs to use TestScheduler.parseMarbles(). I assume that's not even a public API? Maybe it'd be good to extract it into a separate package, so that both rxjs and swirly can depend on it?

[niklas-wortmann]

Good call regarding the circular dependency. I don't know about the TestScheduler.parseMarbles() API, but I think as quick fix I could just move the marble diagram generation over to the docs_app.

[niklas-wortmann]

timdp/swirly#2 Is kinda related to this pr as the generated SVGs could be improved in terms of accessibility

[timdp]

I've also introduced a workaround for the circular-ish dependency. As of v0.13.6, instead of depending on RxJS directly, the parser now uses a tree-shaken copy of TestScheduler.parseMarbles(). So it's a rudimentary way of extracting the logic into a minimal package, at the expense of duplicating it.

[benlesh]

It's nice that these have finally been detached from the tests. I've always felt they shouldn't be related, but it was a reasonable compromise to hand-rolling them.

[benlesh]

LGTM... @niklas-wortmann ... I'll let you merge this one. You probably want to cherry pick it over to 6.x as well, so I recommend doing a squash and merge.

[timdp]

Little bug: in package.json, you're depending on the swirly package directly, and pulling in all its dependencies (including Puppeteer) as a result.

[niklas-wortmann]

Oh I see, good call. Thanks yeah now that makes sense. I will fix that

[niklas-wortmann]

@benlesh I don't think I will cherry pick it in V6. There's still a lot of work needed for that and I don't want to deal with the hassle :D Also it makes the V7 release even better having lots of great docs stuff too :D

[timdp]

I'm a big fan of depcheck to avoid stuff like this. Could be something for a follow-up PR. :-)