Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forkjoin marbel diagram is wrong. #5416

Closed
its-dibo opened this issue May 7, 2020 · 5 comments
Closed

forkjoin marbel diagram is wrong. #5416

its-dibo opened this issue May 7, 2020 · 5 comments
Labels
docs Issues and PRs related to documentation

Comments

@its-dibo
Copy link

its-dibo commented May 7, 2020

in forkJoin doc, the documentation says that the output observable emmits values in the same order of the input observables.

but in the attached marbel diagram, it dosen't.
the output value is (e ,4 ,j)
i.e: values emitted by obs1, obs3, obs2 (not obs1, obs2, obs3)

the expected result is: (e, j, 4) and not (e, 4, j)

image

@cartant cartant added the docs Issues and PRs related to documentation label May 8, 2020
@sijusamson
Copy link

@cartant is anyone assigned for this ?

@cartant
Copy link
Collaborator

cartant commented May 16, 2020

@sijusamson No, but I doubt this can be fixed ATM because the marble diagram generation is currently being changed.

@sijusamson
Copy link

So do i need to work on this ?

@cartant
Copy link
Collaborator

cartant commented May 19, 2020

@sijusamson see the links in this comment and the PR in which it was made. The marble diagram generation is being completely replaced, so I don't think there's anything that you can do, ATM. However, if you want to acquaint yourself with Swirly - see #5019 - it's highly likely that you'll be able to help with the generation of the new diagrams soon, if that's something you'd be interested in. If that is the case, keep an eye on #5422.

@jakovljevic-mladen
Copy link
Member

Closing as fixed in #4940.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and PRs related to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants