-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to get Travis-CI builds working #194
Conversation
Partial success with the last commit. As for RDKit, it got past the Until we get MOPAC etc running we're not going to be able to do QM things, so I'm tempted to try a build config that doesn't try QM (and thus won't need the InChI support, I think…?) |
On Fri, Mar 28, 2014 at 03:17:44PM -0700, Richard West wrote:
You can (apparently) cache these builds to save time in later runs 1.
That's nice, but surprising. Travis claims to use isolated
And it probably failed (if it even got that far) for Python 2.6, since |
I think the cacheing is only for private repositories so we'd have to pay $129/month. |
On Fri, Mar 28, 2014 at 03:39:06PM -0700, Richard West wrote:
Ah, that explains why I hadn't seen it in other projects using Travis
Lovely. That is much nicer than building them for each test. |
Making progress. Couple of problems.
|
There are also warnings like: $ pip install numpy --use-mirrors which are probably due to my copy-pasting from an out-of-date section You can probably drop the 'pip install .' too, since everything |
Yay. No more segfaults. Some unit tests fail (we expect that) but it runs to completion. Still to fix:
|
PyDAS and PyDQED now fixed. |
It would have been nice if PyDAS and PyDQED were not forked, because now they will always refer to jwallen's repository as master even though he will not longer be actively updating. |
The builds got this far then stopped for 10 minutes and were killed: $ git clone [email protected]:GreenGroup/RMG-database.git Cloning into 'RMG-database'... The authenticity of host 'github.com (192.30.252.128)' can't be established. RSA key fingerprint is 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48. Are you sure you want to continue connecting (yes/no)? Hopefully the https version can continue without the RSA fingerprint check...
Currently it spends thousands of lines of log file (and quite some time) compiling scipy for each build. The Ubuntu apt-get install of python-scipy should save this, but you need to enable the system site packages (instead of the isolated virtual environment) to use it. [1,2] Hopefully this (using the system site packages) also fixes the apparent failure of rdkit: current build failed with: echo "Checking you have rdkit..." Checking you have rdkit... Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: No module named rdkit [1] http://danielnouri.org/notes/2012/11/23/use-apt-get-to-install-python-dependencies-for-travis-ci/ [2] https://github.com/dnouri/nolearn/blob/master/.travis.yml
Trying to get the simplest possible configuration working first, then will add complexity.
--use-mirrors has been deprecated, and pip install . likely isn't needed
This should speed up and simplify the build, if it works.
These lines in the build script are based off the RDKit travis config https://github.com/rdkit/rdkit/blob/master/.travis.yml But modified to turn on InChI support Once this is working we can worry about cacheing the finished build to speed it up.
Unlike the instructions for users in our installation guide, don't have Travis sudo the make install for PyDAS and PyDQED. 'sudo' on Ubuntu makes it discover the wrong python, which then doesn't have Cython installed, and it all goes wrong. Hopefully this clears it up. I also split into several lines, to make debugging the Travis log easier.
- RMG-database - RPyDAS - RPyDQED - Rrdkit etc. should all live alongside, not inside, the RMG-Py directory. Hopefully this works solves the database problem
Getting Travis-CI builds working
Getting Travis-CI builds working
This is where we get Travis-CI continuous integration working!
For some reason Github think my rwest/RMG-Py is no longer the same project as GreenGroup/RMG-Py and I cannot send pull requests. While I wait for them to fix this, I have pushed this topic branch to GreenGroup and am sending the pull request from there.
I wanted to do it via a pull request to see how the Travis-CI thing handles it, and because it may take several commits to get right…
Let's not merge until it seems to be working
https://travis-ci.org/GreenGroup/RMG-Py/
Current status: