Progress towards fixing unit tests #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions. Hopefully Josh will alert us to any improvements he makes, now that he has left. I also switched to https instead of git, so that you don't need a github account and login etc. I also tweak the linux installation instructions. Just formatting, really.
It turns out that this bit of code was correct, but hopefully now it's clearer. It's still pretty confusing where this is set, and in what priority. (eg. the .rmgrc config file). I'm not sure why the prior one seems to work in other places
This is a proof (test) of concept. If it works, then we should add this decorator to all the unit tests that we currently EXPECT to fail. That way, the Travis-CI build test will pass - the failing tests will just be skipped if they fail (still with an error message). We shouldn't forget to go and fix the tests though!
connie
added a commit
that referenced
this pull request
Apr 1, 2014
Progress towards fixing unit tests. There are some fixes to the makefile, instructions, and default database location. Also, a work_in_progress decorator, that we should use to annotate any Unit Tests that we currently expect to fail. You just add @work_in_progress to the line before the unit test definition. If someone could do that for all the currently failing tests, as a half-way house to actually making them work, we will at least be able to detect changes and extra errors.
|
On Tue, Apr 01, 2014 at 02:05:34PM -0700, Richard West wrote:
+1 to pulling these out into a separate PR :). Everything in here looks good to my outsider's eyes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are pre-requisites to the travis continuous-integration thing (separate pull request #194).
There are some fixes to the makefile, instructions, and default database location.
Also, a work_in_progress decorator, that we should use to annotate any Unit Tests that we currently expect to fail.
I did a couple. You just add
@work_in_progressto the line before the unit test definition.If someone could do that for all the currently failing tests, as a half-way house to actually making them work, we will at least be able to detect changes and extra errors.