Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer
DESCRIPTION
overrenv
#8Prefer
DESCRIPTION
overrenv
#8Changes from 3 commits
d4ce070
60c7258
85878a5
9373b68
5f90da5
ac7f846
544167e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 1 in Dockerfile
GitHub Actions / hadolint
Check failure on line 1 in Dockerfile
GitHub Actions / hadolint
Check failure on line 1 in Dockerfile
GitHub Actions / hadolint
Check failure on line 1 in Dockerfile
GitHub Actions / hadolint
Check failure on line 4 in Dockerfile
GitHub Actions / hadolint
Check failure on line 4 in Dockerfile
GitHub Actions / hadolint
Check failure on line 4 in Dockerfile
GitHub Actions / hadolint
Check failure on line 4 in Dockerfile
GitHub Actions / hadolint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this seems unnecessary now that you're not installing
git
, but I suppose you left it in to make it easy to add system installs in the future?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, all of this is just the skeleton/ infrastructure for a "very soon-to-come"
main.R
script, that will likely have at least SOME system dependencies.Check failure on line 24 in Dockerfile
GitHub Actions / hadolint
Check failure on line 24 in Dockerfile
GitHub Actions / hadolint