Prefer DESCRIPTION over renv
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyetman
reviewed
Feb 15, 2024
cjyetman
reviewed
Feb 15, 2024
cjyetman
previously approved these changes
Feb 15, 2024
cjyetman
previously approved these changes
Feb 15, 2024
AlexAxthelm
previously approved these changes
Feb 16, 2024
Merged
cjyetman
reviewed
Feb 16, 2024
| @@ -2,20 +2,22 @@ FROM --platform=linux/amd64 rocker/tidyverse | |||
|
|
|||
| # install system dependencies for R packages | |||
| RUN apt-get update \ | |||
There was a problem hiding this comment.
nit: this seems unnecessary now that you're not installing git, but I suppose you left it in to make it easy to add system installs in the future?
There was a problem hiding this comment.
Correct, all of this is just the skeleton/ infrastructure for a "very soon-to-come" main.R script, that will likely have at least SOME system dependencies.
cjyetman
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for handling dependencies
Relates a little to #7