Feat/13 add json schema #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker image from this PR (f0f153b) created |
|
Note that as of acf0d8e, this is installing the GitHub version of |
cjyetman
approved these changes
Feb 1, 2024
|
Merging to unblock development, but opening an issue to improve documentation so that we're all comfortable with what's happening here |
jdhoffa
reviewed
Feb 1, 2024
| Along with portfolios (in a standardized `csv` format), the parser exports a metadata file about the parsed inputs, and the exported portfolio files. | ||
| The file is in JSON format, and validates against a [JSON Schema in this repository](inst/extdata/schema/parsedPortfolio_0-1-0.json). | ||
|
|
||
| The file is array of objects, with the highest level opbects in the array centered around the input files, with the exported files contained in an array with the `portfolio` key in each input file object. |
| "package": "digest", | ||
| "version": "0.6.33" | ||
| }, | ||
| // ... array elided |
|
Merged before I could comment, but some potential typos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a JSON schema, validation logic to processing files, and metadata export
Closes #13
Closes #14