Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/98 update log suppression #99

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

AlexAxthelm
Copy link
Contributor

Closes #98

Copy link

github-actions bot commented Oct 25, 2024

Docker build status

commit_time git_sha image
2024-10-25T14:16:44Z 5087f8d ghcr.io/rmi-pacta/workflow.pacta:pr-99

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.35%. Comparing base (92cacfa) to head (5087f8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   18.35%   18.35%           
=======================================
  Files           4        4           
  Lines         414      414           
=======================================
  Hits           76       76           
  Misses        338      338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jdhoffa
jdhoffa previously approved these changes Oct 25, 2024
@AlexAxthelm
Copy link
Contributor Author

Ready for review. Looking into the JSON Schema check failing in separate thread.

@AlexAxthelm AlexAxthelm requested a review from jdhoffa October 25, 2024 14:32
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still looks good!

@AlexAxthelm AlexAxthelm merged commit c07fd4c into main Oct 25, 2024
30 of 31 checks passed
@AlexAxthelm AlexAxthelm deleted the fix/98-update-log-suppression branch October 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version of logger breaking tests on MacOS
2 participants