Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/53 convert to package #54

Merged
merged 42 commits into from
May 21, 2024
Merged

Refactor/53 convert to package #54

merged 42 commits into from
May 21, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented May 13, 2024 •
edited
Loading

Convert Scripts to functions and restructure repo as R package

closes #53

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

Docker build status

commit_time git_sha image
2024-05-20T14:56:10Z 6de8f86 ghcr.io/rmi-pacta/workflow.pacta:pr-54

AlexAxthelm and others added 21 commits May 13, 2024 15:42
@AlexAxthelm
Fix issues found in local testing
dd89f4d
@AlexAxthelm
Merge branch 'main' into refactor/53-convert-to-package
b90a3f3
@AlexAxthelm
Add logger functions to namespace and use in code
fd5dfaa
@AlexAxthelm
Low-hanging fruit linting
cd26297
@AlexAxthelm
linting in run_audit
f3b0449
@AlexAxthelm
Add minimal loggin to run_pacta
0ffcd81
@AlexAxthelm
Low-fruit linting in run_analysis
a0003cf
@AlexAxthelm
namespace dependencies
39bdd4d
@AlexAxthelm
linting in run_analysis function
193913c
@AlexAxthelm
Update docker-compose
3b29c13
@AlexAxthelm
Use branch of pacta.portfolio.audit
c9137e7
@AlexAxthelm
Fix non-standard ref syntax
83e6b41 
https://r-lib.github.io/pkgdepends/reference/pkg_refs.html#the-remotes-field
@AlexAxthelm
update Rbuildignore
a199959
@AlexAxthelm
reflow comment
2243118
@AlexAxthelm
Reflow long line
41b933c 
function name is very long when namespaced
@AlexAxthelm
Refactor dplyr::mutate to use base commands
7c931fc
@AlexAxthelm
Shorten variable name
bb60f15
@AlexAxthelm
Extract Equity calculation to separate function
e65e5cc
@AlexAxthelm
Initial genericization
58c8178
@AlexAxthelm
Extract Bonds calculations to new function
48a1266
@AlexAxthelm
Initial generalization
c428d36
@codecov Codecov
Copy link

codecov bot commented May 14, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@AlexAxthelm AlexAxthelm mentioned this pull request May 14, 2024
Closed
@AlexAxthelm AlexAxthelm marked this pull request as ready for review May 14, 2024 18:53
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa May 14, 2024 18:53
@AlexAxthelm
Copy link
Contributor Author

note to reviewers:

This isn't ready to merge yet (RMI-PACTA/pacta.portfolio.audit#46) but it appears to be functional, and would be good to build off of as I work on the input params.

In the sprit of not blocking that, there are no exported or documented functions (doing that is tracked as #56)

@jdhoffa
Copy link
Member

jdhoffa commented May 16, 2024

Finally getting around to reviewing this!!

jdhoffa
jdhoffa reviewed May 17, 2024
View reviewed changes
.dockerignore Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@AlexAxthelm AlexAxthelm mentioned this pull request May 20, 2024
Merged
1 task
@AlexAxthelm AlexAxthelm merged commit 70a6db1 into main May 21, 2024
23 checks passed
@AlexAxthelm AlexAxthelm deleted the refactor/53-convert-to-package branch May 21, 2024 08:47
This was referenced May 27, 2024
Open
Open
cjyetman pushed a commit to RMI-PACTA/workflow.cj.pacta that referenced this pull request Jul 12, 2024
Revert "Refactor/53 convert to package (RMI-PACTA#54)"
b56d69c 
This reverts commit 70a6db1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa left review comments

@cjyetman cjyetman cjyetman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert scripts to package structure
3 participants
@AlexAxthelm @jdhoffa @cjyetman