Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/57 use pacta.workflow.utils #58

Merged
merged 56 commits into from
May 22, 2024
Merged

Feat/57 use pacta.workflow.utils #58

merged 56 commits into from
May 22, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented May 20, 2024 •
edited
Loading

AlexAxthelm and others added 30 commits May 13, 2024 13:34
@AlexAxthelm
Add basic package infrastructure
ebae0f5
@AlexAxthelm
Add authors
6174d9d
@AlexAxthelm
Add R package Actions
f9d27df
@AlexAxthelm
Increment version number to 0.0.0.9001
a77dde7
@AlexAxthelm
Reindent DESCRIPTION
14993d1
@AlexAxthelm
Move script files
6ec71ec
@AlexAxthelm
Convert scripts to functions
3fba9e0
@AlexAxthelm
Use new invokation pattern in docker image
fda5aec
@AlexAxthelm
Fix issues found in local testing
dd89f4d
@AlexAxthelm
Merge branch 'main' into refactor/53-convert-to-package
b90a3f3
@AlexAxthelm
Add logger functions to namespace and use in code
fd5dfaa
@AlexAxthelm
Low-hanging fruit linting
cd26297
@AlexAxthelm
linting in run_audit
f3b0449
@AlexAxthelm
Add minimal loggin to run_pacta
0ffcd81
@AlexAxthelm
Low-fruit linting in run_analysis
a0003cf
@AlexAxthelm
namespace dependencies
39bdd4d
@AlexAxthelm
linting in run_analysis function
193913c
@AlexAxthelm
Update docker-compose
3b29c13
@AlexAxthelm
Use branch of pacta.portfolio.audit
c9137e7
@AlexAxthelm
Fix non-standard ref syntax
83e6b41 
https://r-lib.github.io/pkgdepends/reference/pkg_refs.html#the-remotes-field
@AlexAxthelm
update Rbuildignore
a199959
@AlexAxthelm
reflow comment
2243118
@AlexAxthelm
Reflow long line
41b933c 
function name is very long when namespaced
@AlexAxthelm
Refactor dplyr::mutate to use base commands
7c931fc
@AlexAxthelm
Shorten variable name
bb60f15
@AlexAxthelm
Extract Equity calculation to separate function
e65e5cc
@AlexAxthelm
Initial genericization
58c8178
@AlexAxthelm
Extract Bonds calculations to new function
48a1266
@AlexAxthelm
Initial generalization
c428d36
@AlexAxthelm
Generalize filenames
18e956d
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

Docker build status

commit_time git_sha image
2024-05-21T15:10:36Z 0a79a1b ghcr.io/rmi-pacta/workflow.pacta:pr-58

@AlexAxthelm AlexAxthelm marked this pull request as ready for review May 21, 2024 15:13
@AlexAxthelm AlexAxthelm requested a review from cjyetman May 21, 2024 15:13
@AlexAxthelm AlexAxthelm merged commit 22070c9 into main May 22, 2024
22 checks passed
@AlexAxthelm AlexAxthelm deleted the feat/57-use-pacta.workflow.utils branch May 22, 2024 07:34
@AlexAxthelm AlexAxthelm mentioned this pull request May 23, 2024
Closed
cjyetman pushed a commit to RMI-PACTA/workflow.cj.pacta that referenced this pull request Jul 12, 2024
Revert "Feat/57 use pacta.workflow.utils (RMI-PACTA#58)"
88747bb 
This reverts commit 22070c9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @cjyetman