Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hadolint action #13

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Add hadolint action #13

merged 2 commits into from
Nov 17, 2023

Conversation

AlexAxthelm
Copy link
Contributor

hadolint is a linter for Dockerfile
https://github.com/hadolint/hadolint

@AlexAxthelm AlexAxthelm requested a review from cjyetman November 16, 2023 20:55
Copy link

github-actions bot commented Nov 16, 2023

Docker image from this PR (33af2fe) created

docker pull ghcr.io/rmi-pacta/workflow.pacta:pr13

Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! I do wonder what is the alternative for "Do not use --platform flag with FROM"?

@AlexAxthelm
Copy link
Contributor Author

cool! I do wonder what is the alternative for "Do not use --platform flag with FROM"?

The suggested mechanism to build for alternate platforms is to specify --platform in the build command, rather than the Dockerfile. With buildkit, you can actually target multiple platforms in a single build:

docker buildx build --platform linux/amd64,linux/arm64 .

@cjyetman
Copy link
Member

cool! I do wonder what is the alternative for "Do not use --platform flag with FROM"?

The suggested mechanism to build for alternate platforms is to specify --platform in the build command, rather than the Dockerfile. With buildkit, you can actually target multiple platforms in a single build:

docker buildx build --platform linux/amd64,linux/arm64 .

hmmmmm.... ok, I think I was trying to facilitate using a Docker compose file in which one could set their desired platform, but we're not really using that here anymore

@AlexAxthelm AlexAxthelm merged commit 824b861 into main Nov 17, 2023
2 of 4 checks passed
@AlexAxthelm AlexAxthelm deleted the feature/hadolint branch November 17, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants