Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logging package, and clean logging strings #76

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Change logging package, and clean logging strings #76

merged 1 commit into from
Jan 19, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

This PR:

  • changes out the logging package from {rlog} to {logger},
  • standardizes the format for string interpolation (using {glue} via logger::formatter_glue())
  • Cleans up the logging strings:
    • End strings with a single .
    • Quoting filenames

@AlexAxthelm AlexAxthelm mentioned this pull request Jan 19, 2024
Closed
jdhoffa
jdhoffa approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT comment/ question, otherwise LGTM

run_pacta_data_preparation.R Show resolved Hide resolved
@AlexAxthelm AlexAxthelm added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 7c9feed Jan 19, 2024
1 check passed
@AlexAxthelm AlexAxthelm deleted the feature/logger branch January 19, 2024 11:13
@cjyetman cjyetman mentioned this pull request Mar 13, 2024
Open
@cjyetman cjyetman linked an issue Mar 13, 2024 that may be closed by this pull request
feat: write STDOUT log to file #17
Open
@cjyetman cjyetman removed a link to an issue Apr 17, 2024
feat: write STDOUT log to file #17
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman Awaiting requested review from cjyetman cjyetman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @jdhoffa