Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common R action #480

Merged
merged 20 commits into from
Jun 11, 2024
Merged

Add common R action #480

merged 20 commits into from
Jun 11, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Jun 4, 2024 •
edited
Loading

Add standard R checking workflows from the RMI-PACTA/actions repo.

Relates to:

@AlexAxthelm AlexAxthelm requested a review from jacobvjk as a code owner June 4, 2024 15:46
@cjyetman
Copy link
Member

cjyetman commented Jun 5, 2024

probably doesn't make sense to add this without removing the existing R CMD checks

jdhoffa
jdhoffa requested changes Jun 6, 2024
View reviewed changes
.github/workflows/R.yml Outdated

dev-r-cmd-check:
name: R CMD Check (dev versions)
uses: RMI-PACTA/actions/.github/workflows/R-CMD-check.yml@add-extra-repos-to-rcmdcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action still depends on a PR branch, please merge that branch first

@jdhoffa
Copy link
Member

jdhoffa commented Jun 6, 2024

Depends on RMI-PACTA/actions#90

@AlexAxthelm AlexAxthelm mentioned this pull request Jun 6, 2024
Merged
AlexAxthelm and others added 2 commits June 6, 2024 15:53
@AlexAxthelm
add .lintr to Rbuildignore
f8c49c1
@AlexAxthelm
Check docs action (#482)
43a2822 
* Remove examples from prioritize

* Revert "Remove examples from prioritize"

This reverts commit 65b1c78.

* Move external markdown reference to inline

Thanks to @jdhoffa for the catch.

* version bump
jdhoffa
jdhoffa requested changes Jun 7, 2024
View reviewed changes
R/prioritize.R Outdated Show resolved Hide resolved
@AlexAxthelm AlexAxthelm marked this pull request as draft June 7, 2024 09:31
AlexAxthelm and others added 4 commits June 7, 2024 11:37
@AlexAxthelm
fix typo
73dadd9
@AlexAxthelm
Resolve dev version dependencies (#484)
faa2d12 
* Explicitly upgrade packages for dev checks
* use cache-version to separate caches
@AlexAxthelm
Merge branch 'main' into use-rmi-actions
8321f4c
@AlexAxthelm
Use r universe (#485)
a48a9a8 
* Use remotes, not repos
@AlexAxthelm AlexAxthelm marked this pull request as ready for review June 7, 2024 13:18
AlexAxthelm and others added 4 commits June 7, 2024 15:30
@AlexAxthelm
Use main branch of workflow
4aab79d
@AlexAxthelm
Trigger CI
660de76
@AlexAxthelm
Trigger CI after updating action
cf6332a
@AlexAxthelm
Use fix branch of action (#486)
41c558e 
* Use fix branch of action

* Revert "Use fix branch of action"

This reverts commit 2977c30.
@AlexAxthelm AlexAxthelm requested a review from jdhoffa June 7, 2024 14:12
@AlexAxthelm AlexAxthelm mentioned this pull request Jun 10, 2024
Open
@AlexAxthelm
Copy link
Contributor Author

Note that with this PR, we're testing the HEAD (latest version of main or PR) against both the CRAN and latest main versions of all dependencies.

Note that when we are testing against the dev versions of the dependencies, it is for the RMI-PACTA packages only (for example, dplyr is still the CRAN version).

This was referenced Jun 10, 2024
Closed
Closed
Closed
@AlexAxthelm
Copy link
Contributor Author

@jdhoffa I believe the requested changes were made in #483

@AlexAxthelm AlexAxthelm mentioned this pull request Jun 10, 2024
Closed
@AlexAxthelm AlexAxthelm self-assigned this Jun 10, 2024
jdhoffa
jdhoffa approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AlexAxthelm AlexAxthelm merged commit bf62689 into main Jun 11, 2024
25 checks passed
@AlexAxthelm AlexAxthelm deleted the use-rmi-actions branch June 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvjk jacobvjk jacobvjk approved these changes

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees

@AlexAxthelm AlexAxthelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAxthelm @cjyetman @jdhoffa @jacobvjk