Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "devel" R CMD CHECK workflow #387

Closed
AlexAxthelm opened this issue Jun 10, 2024 · 0 comments · Fixed by #388
Closed

Remove "devel" R CMD CHECK workflow #387

AlexAxthelm opened this issue Jun 10, 2024 · 0 comments · Fixed by #388

Comments

@AlexAxthelm
Copy link
Contributor

AlexAxthelm commented Jun 10, 2024

Given that this package doesn't have any dependencies on other RMI-PACTA repos (either as "hard" Imports, or "soft" Suggests), running R CMD CHECK with the dev versions of r2dii.match and .analysis doesn't make much sense, since there isn't anything called from those repos.

Can anyone think of a reason to keep this check in here? @RMI-PACTA/r-developers

Context: I'm planning to ensure checks against dev-versions of dependencies in .match (RMI-PACTA/r2dii.match#480) .analysis (RMI-PACTA/r2dii.analysis#501) and .plot (RMI-PACTA/r2dii.plot#567) which captures the "upstream" direction, but do we need to capture "downstream" for some reason (if we're not executing any of that code)

Relates to #386

AlexAxthelm added a commit that referenced this issue Jun 10, 2024
Remove tests against  dev dependencies (there are none)

Closes: #387
@AlexAxthelm AlexAxthelm linked a pull request Jun 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant