Adapt to updated demo data #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fails expected for now, as this depends on the related r2dii.data PR |
jdhoffa
approved these changes
Apr 24, 2024
jdhoffa
added a commit
that referenced
this pull request
Apr 25, 2024
The (brittle) snapshot tests are currently failing when run against the CRAN published `r2dii.data v0.5.0`. They only pass against the dev version of the package. This PR bumps the function that skips snapshot tests with old `r2dii.data`. Another indication that we should prioritize working on #392 Relates to RMI-PACTA/r2dii.data#374 Relates to #473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on RMI-PACTA/r2dii.data#374