-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
257 minimal demo data lbk and abcd #374
Conversation
Just noting that: Otherwise LGTM |
to feel safe about this, I would appreciate you checking the r2dii.match vignettes as well @jdhoffa in case you find time for that |
Testing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I saw no issues when testing against this PR: RMI-PACTA/r2dii.match#473
The (brittle) snapshot tests are currently failing when run against the CRAN published `r2dii.data v0.5.0`. They only pass against the dev version of the package. This PR bumps the function that skips snapshot tests with old `r2dii.data`. Another indication that we should prioritize working on #392 Relates to RMI-PACTA/r2dii.data#374 Relates to #473
closes #257
closes #372
abcd_demo
drops columnsabcd_timestamp
(not needed for calculation) andcountry_of_domicile
(not part of the P4B format ABCD)loanbook_demo
drops columnsid_intermediate_parent_1
,name_intermediate_parent_1
,,sector_classification_input_type
,fi_type
,flag_project_finance_loan
, andname_project
, none of which are needed for the calculationdata_dictionary
is adjusted accordingly and drops the mention of these variablesNOTE:
data_dictionary
. If so, test expectations need to be adjustedThe new demo data sets generate the following demo output
Created on 2024-04-18 with reprex v2.1.0