Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render README action #444

Merged
merged 34 commits into from
Jan 30, 2024
Merged

Fix render README action #444

merged 34 commits into from
Jan 30, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jan 30, 2024

Closes #443

@jdhoffa jdhoffa mentioned this pull request Jan 30, 2024
Merged
@jdhoffa jdhoffa requested a review from jacobvjk January 30, 2024 13:39
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024

Relates to RMI-PACTA/actions#11

@jdhoffa jdhoffa marked this pull request as draft January 30, 2024 13:40
@jdhoffa jdhoffa removed the request for review from jacobvjk January 30, 2024 13:40
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024

Seems like r-lib/actions/setup-renv@v2 is failing

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024 •
edited
Loading

That seems to do it! https://github.com/RMI-PACTA/r2dii.match/actions/runs/7713272963

Though 10min seems long for a check

@jdhoffa jdhoffa marked this pull request as ready for review January 30, 2024 15:51
@jdhoffa jdhoffa requested a review from cjyetman January 30, 2024 15:51
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024

Sorry for the spam @cjyetman , converted back to draft. This is driving me nuts lol

@jdhoffa
test
9862d40
@jdhoffa
Merge branch 'fix_readme_action' of github.com:RMI-PACTA/r2dii.match …
d404efc 
…into fix_readme_action

Add portfolio name as argument to Dockerfile command
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024

Sorry for the spam @cjyetman , converted back to draft. This is driving me nuts lol

Maybe silly to put so much work into it, but I'm committed now XD

@jdhoffa jdhoffa marked this pull request as ready for review January 30, 2024 17:42
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024

Ok it works now lol:
https://github.com/RMI-PACTA/r2dii.match/actions/runs/7715397603/job/21029870364

and only takes 2min

@jdhoffa jdhoffa requested a review from cjyetman January 30, 2024 18:00
This was referenced Jan 30, 2024
Closed
Closed
Closed
@jdhoffa jdhoffa merged commit a5c6189 into main Jan 30, 2024
24 checks passed
@jdhoffa jdhoffa deleted the fix_readme_action branch January 30, 2024 21:28
This was referenced Feb 1, 2024
Merged
Merged
Open
@jdhoffa jdhoffa mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix render-readme.yml action
2 participants
@jdhoffa @cjyetman