Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize and knit README #442

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Modernize and knit README #442

merged 2 commits into from
Jan 31, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jan 30, 2024 •
edited
Loading

Seems the README has not been knit for a while. See #443

See RMI-PACTA/r2dii.data#323

@jdhoffa jdhoffa requested a review from jacobvjk January 30, 2024 09:08
jacobvjk
jacobvjk reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are updating the README file, should we care about the failing check? Although the error seems to be coming from getting an R version, not directly from the rendering

@cjyetman
Copy link
Member

Warning: r-lib/actions/setup-r@v1 is deprecated. Please update your workflow to use the 'v2' version. Also look at the examples at https://github.com/r-lib/actions/tree/v2/examples because '@v2' workflows are much simpler than 'v1' workflows.

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024

See #444, I will try to fix that action there.

Depends on #444

@jdhoffa jdhoffa requested a review from jacobvjk January 30, 2024 21:35
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 30, 2024

Checks now passing :-)

jacobvjk
jacobvjk approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdhoffa jdhoffa merged commit 8081439 into main Jan 31, 2024
24 checks passed
@jdhoffa jdhoffa deleted the modernize_readme branch January 31, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvjk jacobvjk jacobvjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdhoffa @cjyetman @jacobvjk