Remove default force_array for parse_raw_params
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior default (`c("portfolio", "files")`) was causing errors in
tests, and setting it to be an empty default makes sense, when there is
no guarantee that the invocation pattern will match that pattern at run
time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 10 10
Lines 626 626
=======================================
Hits 614 614
Misses 12 12 ☔ View full report in Codecov by Sentry. |
jdhoffa
requested changes
Nov 8, 2024
Co-authored-by: Jackson Hoffart <[email protected]>
jdhoffa
approved these changes
Nov 12, 2024
AlexAxthelm
added a commit
to RMI-PACTA/workflow.pacta.report
that referenced
this pull request
Nov 13, 2024
AlexAxthelm
added a commit
to RMI-PACTA/workflow.pacta
that referenced
this pull request
Nov 13, 2024
2 tasks
AlexAxthelm
added a commit
to RMI-PACTA/workflow.pacta.report
that referenced
this pull request
Nov 14, 2024
* rename param files * Update references to new filenames * Use dev branch of package * Increment version number to 0.0.0.9007 * remove list of explicit inheritence files * use `main` dependency following RMI-PACTA/pacta.workflow.utils#37 * Increment version number to 0.0.0.9008 * force portfolio/files to be an array adapting to RMI-PACTA/pacta.workflow.utils#38 * Increment version number to 0.0.0.9008
AlexAxthelm
added a commit
to RMI-PACTA/workflow.pacta.webapp
that referenced
this pull request
Nov 14, 2024
AlexAxthelm
added a commit
to RMI-PACTA/workflow.pacta.webapp
that referenced
this pull request
Nov 18, 2024
* Update testing configs to use array of filenames * Add more verbose logging in raw params * Revert "Add more verbose logging in raw params" This reverts commit 073f625. * Use dev version of package * Export report manifest * Increment version number to 0.0.1.9002 * Use an unexported function * Use main branch of dependency * Update docker-compose * Use fdev branches of dependencies * WIP - inheritence * Trigger CI * Use new RMI blob copy action (#24) * Use new RMI blob copy action * Add function to prepare schema tempdir * Wrap main workflow in function * Update conditionals for reporting and analysis * update calling script * linting * Use exported function on `develop` branch * rename file to match function name. * Update README * Update buildignore * Copy schema files from this package * Update directory path in script * change from `system.file` to `file.path` * Export function * Linting * Use main branch of de ps * force portfolio/files to be an array adapting to RMI-PACTA/pacta.workflow.utils#38 * Explicitly pass i/o directories * update docs and render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior default (
c("portfolio", "files")) was causing errors in tests, and setting it to be an empty default makes sense, when there is no guarantee that the invocation pattern will match that pattern at run time