Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update param filenames #32

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Update param filenames #32

merged 10 commits into from
Nov 14, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Nov 7, 2024

Update filenames for default parameter files, to avoid name collisions while inheriting (analysis_2023Q4.json and reporting_2023Q4.json, rather than both being named 2023Q4.json)

Depends on:

Relates to:

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (bc18fde) to head (ab24161).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #32   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4       4           
  Lines        501     501           
=====================================
  Misses       501     501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 7, 2024

Docker build status

commit_time git_sha image
2024-11-13T15:52:22Z ab24161 ghcr.io/rmi-pacta/workflow.pacta.report:pr-32

Copy link

github-actions bot commented Nov 7, 2024

Report Links

commit_time git_sha config report summary image
2024-11-13T15:52:22Z ab24161 default_2022Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-32
2024-11-13T15:52:22Z ab24161 default_2023Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-32
2024-11-13T15:52:22Z ab24161 full_params_2023Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.report:pr-32

@AlexAxthelm AlexAxthelm marked this pull request as ready for review November 13, 2024 12:33
@AlexAxthelm AlexAxthelm marked this pull request as draft November 13, 2024 15:33
@AlexAxthelm AlexAxthelm self-assigned this Nov 13, 2024
@AlexAxthelm AlexAxthelm requested a review from jdhoffa November 13, 2024 16:03
@AlexAxthelm AlexAxthelm marked this pull request as ready for review November 13, 2024 16:03
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions (mainly for my own understanding) but otherwise looks good

inst/extdata/schema/rawParameters.json Show resolved Hide resolved
inst/extdata/scripts/run_pacta_report.R Show resolved Hide resolved
@AlexAxthelm AlexAxthelm merged commit 9fe132f into main Nov 14, 2024
29 checks passed
@AlexAxthelm AlexAxthelm deleted the update-param-filenames branch November 14, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants