Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: deal with Linter errors #29

Closed
jdhoffa opened this issue Aug 19, 2024 · 2 comments · Fixed by #103
Closed

style: deal with Linter errors #29

jdhoffa opened this issue Aug 19, 2024 · 2 comments · Fixed by #103
Assignees
@MonikaFu
Labels
ADO Also Tracked on Azure DevOps good first issue Good for newcomers

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Aug 19, 2024 •
edited by github-actions bot
Loading

The linter is currently failing: https://github.com/RMI-PACTA/pacta-dashboard-svelte/actions/runs/10422846547/job/28868359633?pr=28

It seems like lots of our JavaScript code has various issues with it (variables defined but never used, etc.)

We should tidy up our JavaScript code, and ideally ensure that the Linter on CI passes

AB#11699
@jdhoffa jdhoffa added the good first issue Good for newcomers label Aug 19, 2024
@jdhoffa jdhoffa mentioned this issue Aug 19, 2024
Merged
@MonikaFu
Copy link
Contributor

yup, agreed. I'd say we should deal with it when we're updating the JS code for resizing etc

@jdhoffa
Copy link
Member Author

jdhoffa commented Aug 19, 2024

Agreed

@jdhoffa jdhoffa added the ADO Also Tracked on Azure DevOps label Aug 22, 2024
This was referenced Dec 2, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 3, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MonikaFu MonikaFu

Labels
ADO Also Tracked on Azure DevOps good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@jdhoffa @MonikaFu