Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 ensure all svelte routes pass the linter #99

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Dec 2, 2024

I did this by:

  • removing unused imports
  • adding new imports (that were called but never correctly imported)
  • logging all err vars to console (before doing this, I would get the unused var error

@MonikaFu FYI

Relates to #96
Towards #29

@jdhoffa
Copy link
Member Author

jdhoffa commented Dec 2, 2024

@cjyetman @AlexAxthelm I know neither of you know Svelte, but hopefully the changes here seem reasonable enough on inspection. Building and inspecting locally, none of the changed routes show any signs of weirdness

src/routes/company_view.svelte Show resolved Hide resolved
@jdhoffa jdhoffa merged commit 9a28e94 into main Dec 2, 2024
4 of 5 checks passed
@jdhoffa jdhoffa deleted the 29-linter-passes_svelte-routes branch December 2, 2024 16:02
@jdhoffa jdhoffa mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants