run prettier on all JS files in a monolithic make-things-pretty PR

[cjyetman]

@jdhoffa maybe you could run prettier on all JS files in a monolithic make-things-pretty PR?

Automatic processes making unrelated changes to PRs makes things more difficult to review/understand/track/etc.

Originally posted by @cjyetman in #115 (comment)

[jdhoffa]

I spent about a day doing this already to close #29

I don't plan to do that again.

I won't approve PRs that have failing CI checks.

[cjyetman]

you fixed linting, but you did not fix all the things that prettier wants to force us to do, so now whenever someone touches a JS file, prettier is going to force us to make all these formatting changes to things that have been there since long ago.

I'm not asking to submit PRs with un-pretty or un-linty lines (in the precise changes that I made in that PR). I'm asking that when I submit a PR I'm not forced to fix formatting that is not related to the PR. If you just make it do all the fixes you want it to do now, I'll be happy submitting PRs against the super awesome, beautiful, perfect code that is already there.

[jdhoffa]

Please see: #115 (comment)

That has already been done.

The changes were not "formatting", and were entirely related to your PR.

[cjyetman]

you're mixing up what the linter does and what prettier does.... they're not the same

[jdhoffa]

pacta-dashboard-svelte/package.json

Line 13 in e3f8f5a

"lint": "prettier --check . && eslint .",

[cjyetman]

you know what && means, right? 🤣