Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mod versioning #903

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Nov 23, 2024

For a detailed description, see launcher PR: R2Northstar/NorthstarLauncher#828

Supercedes #824.

Testing (RequiredOnClient mod version enabling)

Test scenarios

Core mods

Launch game and join any server:

with `Northstar.Client` local version not matching server version (connection should be allowed);
Nothing special should appear in your logs here.
with `Northstar.Client` disabled (mod should be enabled before connection).
[2024-08-31] [00:33:18] [NORTHSTAR] [info] Attempting authentication with server of id "2fae3133f3822d55461631b86bc7de45"
[2024-08-31] [00:33:19] [SCRIPT UI] [info] Enabled "Northstar.Custom" (v1.19.0) to join server.
Gamemode mods

Install several versions of a same mod (Parkour v0.2.0 + v0.2.1 for instance) then:

Enable/disable any version in any order through the mods menu (should work fine);
multiple_versions_handling.webm
Disable both versions and join a Parkour server (mod with matching version should be enabled);
[2024-08-31] [00:39:33] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.1.2 (DISABLED)
[...]
[2024-08-31] [00:39:33] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.2.1 (DISABLED)
[...]

[2024-08-31] [00:39:43] [NORTHSTAR] [info] Requesting server list from https://northstar.tf
[2024-08-31] [00:39:43] [NORTHSTAR] [info] Got 86 servers
[2024-08-31] [00:39:47] [NORTHSTAR] [info] Attempting authentication with server of id "ff7235e0108a4fb51d278642e9e9b800"
[2024-08-31] [00:39:48] [SCRIPT UI] [info] "Northstar.Custom" (v1.19.0) is required and already enabled.
[2024-08-31] [00:39:48] [SCRIPT UI] [info] Enabled "Parkour" (v0.2.1) to join server.
[...]

[2024-08-31] [00:39:48] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.1.2 (DISABLED)
[...]
[2024-08-31] [00:39:48] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.2.1
Note the server-exposed version, disable it locally and enable the other one, then join the server (current version should be disabled and the other one enabled).
[2024-08-31] [00:42:58] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.1.2
[...]
[2024-08-31] [00:42:58] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.2.1 (DISABLED)
[...]

[2024-08-31] [00:43:26] [NORTHSTAR] [info] Attempting authentication with server of id "ff7235e0108a4fb51d278642e9e9b800"
[2024-08-31] [00:43:27] [SCRIPT UI] [info] "Northstar.Custom" (v1.19.0) is required and already enabled.
[2024-08-31] [00:43:27] [SCRIPT UI] [info] Disabled "Parkour" (v0.1.2) since it's not required on server.
[2024-08-31] [00:43:27] [SCRIPT UI] [info] Enabled "Parkour" (v0.2.1) to join server.
[...]

[2024-08-31] [00:43:27] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.1.2 (DISABLED)
[...]
[2024-08-31] [00:43:27] [NORTHSTAR] [info] 'Parkour' loaded successfully, version 0.2.1

(ask @Alystrasz if Parkour server is not up)

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 23, 2024
@Alystrasz Alystrasz added depends on another PR Blocked until the PR it depends on is merged MAD Related to mod-auto-download labels Nov 23, 2024
@Alystrasz Alystrasz linked an issue Nov 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on another PR Blocked until the PR it depends on is merged MAD Related to mod-auto-download needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Mod version check passes on mismatching version
2 participants