Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod version check passes on mismatching version #773

Open
GeckoEidechse opened this issue Dec 20, 2023 · 1 comment · May be fixed by #903
Open

Mod version check passes on mismatching version #773

GeckoEidechse opened this issue Dec 20, 2023 · 1 comment · May be fixed by #903

Comments

@GeckoEidechse
Copy link
Member

GeckoEidechse commented Dec 20, 2023

In theory, we have a version check that prevents players from joining a server if their version mismatches.

In particular, it was mismatch on MAJOR version IIRC. However it seems like this version check is currently not correctly implemented and as such always allows players to join.

To reproduce:

  1. Make sure Northstar.Custom MAJOR version is set to a definitely mismatching value, e.g. do 99.0.0
  2. Join any server
  3. Version check should prevent joining (spoiler alert: it does not atm)
@GeckoEidechse GeckoEidechse changed the title Mod Version check passes on mismatching version Mod version check passes on mismatching version Dec 20, 2023
@GeckoEidechse
Copy link
Member Author

Tbh, with auto-mod-download, I'm starting to wonder if we even need a version check as we can just download the right version on demand.

The only exceptions are:

  1. mods that are not verified (outside of LTS comp servers those basically do not exist)
  2. Northstar.Custom which doesn't strictly follow semver anyway.

That being said, we should either fix or fully remove the check. Persoanlly, I'm tending more towards fixing atm.

@Alystrasz Alystrasz linked a pull request Nov 14, 2024 that will close this issue
@Alystrasz Alystrasz removed a link to a pull request Nov 23, 2024
@Alystrasz Alystrasz linked a pull request Nov 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant